Added npx prefix to react-native commands within docs#1636
Merged
nearestnabors merged 1 commit intofacebook:masterfrom Feb 17, 2020
cepem:consistent-rn-commands
Merged
Added npx prefix to react-native commands within docs#1636nearestnabors merged 1 commit intofacebook:masterfrom cepem:consistent-rn-commands
nearestnabors merged 1 commit intofacebook:masterfrom
cepem:consistent-rn-commands
Conversation
…y consistent with the homepage examples
|
Deploy preview for react-native ready! Built with commit 80cee32 https://deploy-preview-1636--react-native.netlify.com Changes to Thank you for your contributions. |
nearestnabors
suggested changes
Feb 17, 2020
Contributor
nearestnabors
left a comment
There was a problem hiding this comment.
This makes sense! Thank you for your attention to detail!
Contributor
nearestnabors
left a comment
There was a problem hiding this comment.
Woops, meant to approve this. Congrats on your first contribution! Hope to see you here in the future!
kaioduarte
pushed a commit
to kaioduarte/react-native-website
that referenced
this pull request
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in the docs the 'react-native' command sometimes doesn't have the 'npx' prefix and sometimes it does.
Considering that we're using it with 'npx' on the front page, I believe it would be a good idea to stay consistent through all the docs with it.