Refactor AccessibilityInfo Example into React Hooks#1629
Merged
nearestnabors merged 4 commits intofacebook:masterfrom Feb 22, 2020
Merged
Refactor AccessibilityInfo Example into React Hooks#1629nearestnabors merged 4 commits intofacebook:masterfrom
nearestnabors merged 4 commits intofacebook:masterfrom
Conversation
|
Deploy preview for react-native ready! Built with commit e75d16a https://deploy-preview-1629--react-native.netlify.com Changes to Thank you for your contributions. |
Contributor
Author
|
Apologies for the messed up deploy-preview -I have now fixed the code- could the preview perhaps be re-run? |
nearestnabors
suggested changes
Feb 17, 2020
Contributor
nearestnabors
left a comment
There was a problem hiding this comment.
Hello, my friend!
I have had a look at your changes here: https://deploy-preview-1629--react-native.netlify.com/docs/accessibilityinfo
We are alllllmost there! A few things:
- Can you use the
<div class="toggler">template from the original issue to include both the old class example and your new one? #1579 - I see a JSX block and a Snack block here... I suspect you only intended to have Snack Players! Please take a look :)
Thank you so much for taking this on!
nearestnabors
approved these changes
Feb 22, 2020
Contributor
nearestnabors
left a comment
There was a problem hiding this comment.
Thank you so much for submitting this! And congratulations on your first React Native merge! We hope you will come back with more!!
Closed
kaioduarte
pushed a commit
to kaioduarte/react-native-website
that referenced
this pull request
Feb 24, 2020
* Rewrite jsx example using React Hooks * Add a SnackPlayer example * Remove redundant character * Embed functional and class component in toggler syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1579
Please note: I’ve tested with SnackPlayer and the version of React Native it uses underneath does not include the methods
isReduceMotionEnabledandisScreenReaderEnabledfrom the AccessibilityInfo API. For that reason, I usedfetchin the Snack example.