docs: consistency for optional properties#1621
Merged
nearestnabors merged 1 commit intofacebook:masterfrom Feb 11, 2020
Merged
Conversation
|
Deploy preview for react-native ready! Built with commit 273aad0 https://deploy-preview-1621--react-native.netlify.com Changes to Thank you for your contributions. |
Contributor
nearestnabors
left a comment
There was a problem hiding this comment.
Nice catch! We really need to standardize optional properties, default values, and ReadOnlies.
kaioduarte
pushed a commit
to kaioduarte/react-native-website
that referenced
this pull request
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed description of PushNotificationIOS Methods to have consistent format for optional properties.