ActivityIndicator: add snackplayer/functional component with hooks#1590
ActivityIndicator: add snackplayer/functional component with hooks#1590nearestnabors merged 5 commits intofacebook:masterfrom ronnycoding:patch-1
Conversation
|
Oops, something went wrong with this deploy preview. @charpeni can you look at this? |
nearestnabors
left a comment
There was a problem hiding this comment.
Ach, you've don't this in the versioned docs! We need the file to be edited here:
https://github.com/facebook/react-native-website/blob/master/docs/activityindicator.md
| "toastandroid": { | ||
| "title": "ToastAndroid" | ||
| }, | ||
| "toolbarandroid": { |
There was a problem hiding this comment.
@ronnyiscoding Same problem here.
There was a problem hiding this comment.
Thank you for the changes.
As @rachelnabors said (which apply for the both PRs) you should update:
masterdocs (docs/activityindicator.md)
not:
versioneddocs (website/versioned_docs/version-0.61/activityindicator.md)
Thanks for the review, PR is updated please let me know if this is the right way to contribute 👍 |
nearestnabors
left a comment
There was a problem hiding this comment.
Nicely done! Thanks for adding these examples!
Prettifying the code
|
Deploy preview for react-native ready! Built with commit caedf1b https://deploy-preview-1590--react-native.netlify.com Changes to Thank you for your contributions. |
…ebook#1590) * added snackplayer/functional component with hooks * update docs * restore changes * PR updates * Update activityindicator.md Prettifying the code Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Open Issue: #1579