Skip to content

Update docs for React Navigation 5#1578

Merged
nearestnabors merged 2 commits intofacebook:masterfrom
satya164:@satya164/navigation-docs
Feb 7, 2020
Merged

Update docs for React Navigation 5#1578
nearestnabors merged 2 commits intofacebook:masterfrom
satya164:@satya164/navigation-docs

Conversation

@satya164
Copy link
Copy Markdown
Contributor

@satya164 satya164 commented Feb 4, 2020

The current documentation refers to React Navigation 4. We're about to publish new major version of React Navigation, so I have updated the documentation.

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Feb 4, 2020

Deploy preview for react-native ready!

Built with commit fbe877a

https://deploy-preview-1578--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@satya164 satya164 force-pushed the @satya164/navigation-docs branch from 6d6e6fe to 9e5c07d Compare February 4, 2020 16:24
@nearestnabors
Copy link
Copy Markdown
Contributor

Oooh, what a noble update! Have you read our contribution styleguide? Things like using "you" to refer to the reader instead of "we" (which refers to React Native as an entity and the people writing the docs!) Would be awesome if you could check this guide and do another pass!

@satya164
Copy link
Copy Markdown
Contributor Author

satya164 commented Feb 4, 2020

Oops! I'll take a look and update. Thank you!

@satya164 satya164 force-pushed the @satya164/navigation-docs branch from 9e5c07d to df0b64d Compare February 4, 2020 19:36
@satya164 satya164 marked this pull request as ready for review February 5, 2020 15:35
@satya164 satya164 force-pushed the @satya164/navigation-docs branch from df0b64d to 45845bd Compare February 5, 2020 20:16
Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

@nearestnabors nearestnabors merged commit 32f2608 into facebook:master Feb 7, 2020
espipj pushed a commit to espipj/react-native-website that referenced this pull request Feb 8, 2020
* Update docs for React Navigation 5

* Update navigation.md

tweaks

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
kaioduarte pushed a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
* Update docs for React Navigation 5

* Update navigation.md

tweaks

Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants