[DOC]: API Reference for DevSettings.addMenuItem() #1523#1539
[DOC]: API Reference for DevSettings.addMenuItem() #1523#1539nearestnabors merged 4 commits intofacebook:masterfrom
Conversation
|
Deploy preview for react-native ready! Built with commit 53cd431 https://deploy-preview-1539--react-native.netlify.com Changes to Thank you for your contributions. |
|
Hey @rickhanlonii just need you to review DevSettings API reference #1539 to see if i wrote it correctly or need some changes! |
|
any updates ? @rickhanlonii |
|
This pull request solved issue ref #1523 |
rickhanlonii
left a comment
There was a problem hiding this comment.
LGTM, can we also move this to the API sidebar after DatePickerAndroid?
docs/devsettings.md
Outdated
| ```jsx | ||
| addMenuItem(title: string, handler: () => ) | ||
| ``` | ||
| It allows users to add additional dev menu options to their app, so you can use following code to show secret dev screen |
There was a problem hiding this comment.
| It allows users to add additional dev menu options to their app, so you can use following code to show secret dev screen | |
| Add a custom menu item to the developer menu: |
mohamedsgap
left a comment
There was a problem hiding this comment.
Hi, @rickhanlonii Thanks for reviewing my pull request, I've just made an update according to your suggestion.
|
Just made an update according to you suggestion, Let's merge the PR :) @rickhanlonii |
|
Just one last fix 👍 |
Co-Authored-By: Ricky <rickhanlonii@gmail.com>
|
@rickhanlonii just made an update according to your last suggestion ;) |
…ebook#1539) * started doc addMenuItem * added API reference DevSettings * Update DevSettings API reference * Update docs/devsettings.md Co-Authored-By: Ricky <rickhanlonii@gmail.com> Co-authored-by: Ricky <rickhanlonii@gmail.com>
…ebook#1539) * started doc addMenuItem * added API reference DevSettings * Update DevSettings API reference * Update docs/devsettings.md Co-Authored-By: Ricky <rickhanlonii@gmail.com> Co-authored-by: Ricky <rickhanlonii@gmail.com>
Started writing the doc for addMenuItem() as DevSettingsModule.