[Docs][New Guide Structure] Join props.md and state.md in the basics#1114
Merged
nearestnabors merged 20 commits intofacebook:masterfrom Feb 17, 2020
ecreeth:remove-props-and-state
Merged
[Docs][New Guide Structure] Join props.md and state.md in the basics#1114nearestnabors merged 20 commits intofacebook:masterfrom ecreeth:remove-props-and-state
nearestnabors merged 20 commits intofacebook:masterfrom
ecreeth:remove-props-and-state
Conversation
|
Deploy preview for react-native ready! Built with commit 3b4400d https://deploy-preview-1114--react-native.netlify.com Changes to Thank you for your contributions. |
Contributor
|
Nice! Can you work on the state section? |
Contributor
Author
|
Of course, I'm going to finish it! |
charpeni
suggested changes
Aug 28, 2019
Contributor
charpeni
left a comment
There was a problem hiding this comment.
Left some comments and that PR has conflicts.
Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com>
Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com>
Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com>
Contributor
|
@ecreeth Great! Mind pulling down the latest from master and seeing if it fixes that language linting error? |
Contributor
Author
|
@rachelnabors is done! |
kaioduarte
pushed a commit
to kaioduarte/react-native-website
that referenced
this pull request
Feb 24, 2020
…ebook#1114) * remove NavigatorIOS * remove style.md and props.md * add props to Learn The Basics * explain a little better what is happening in HelloWorldApp * Update tutorial.md * add some information to the state * add state example using the player * Update tutorial.md * Update docs/tutorial.md Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com> * Update docs/tutorial.md Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com> * Apply suggestions from code review Co-Authored-By: Nicolas Charpentier <nicolas.charpentier079@gmail.com> * update tutorial.md * Update tutorial.md * fix lint Co-authored-by: Christoph Nakazawa <cpojer@fb.com> Co-authored-by: Nicolas Charpentier <nicolas.charpentier079@gmail.com> Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #929
This PR remove
props.md&style.mdfromThe Basicssection and are rolled intoLearn The BasicsTODO
deleteprops.mddeletestyle.mdprops.mdandstyle.mdfrom sidebarsHelloWorldApppropsare with links to reactjs.orgstateare with links to reactjs.org