Fix binary FormData uploads on Android #54917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: facebook#54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. In facebook#54881, users report failing requests attributed to this code path when performing image uploads. Functionally revert this change, as this breaks runtime behaviour. Changelog: [Internal] Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for `FormData` uploads with binary data Differential Revision: D89373824
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Dec 17, 2025
Summary: facebook#54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. In facebook#54881, users report failing requests attributed to this code path when performing image uploads. Functionally revert this change, as this breaks runtime behaviour. Changelog: [Internal] Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for `FormData` uploads with binary data Reviewed By: vzaidman Differential Revision: D89373824
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Dec 17, 2025
Summary: facebook#54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. In facebook#54881, users report failing requests attributed to this code path when performing image uploads. Functionally revert this change, as this breaks runtime behaviour. Changelog: [Internal] Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for `FormData` uploads with binary data Reviewed By: vzaidman Differential Revision: D89373824
|
This pull request has been merged in 9692e64. |
Collaborator
|
This pull request was successfully merged by @huntie in 9692e64 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
Summary: Pull Request resolved: #54917 #54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. In #54881, users report failing requests attributed to this code path when performing image uploads. Functionally revert this change, as this breaks runtime behaviour. Changelog: [Internal] Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for `FormData` uploads with binary data Reviewed By: vzaidman Differential Revision: D89373824 fbshipit-source-id: 9f144f075db3f9ad5df8598d0f113655466896cf
Collaborator
|
This pull request was successfully merged by @huntie in 471ef72 When will my fix make it into a release? | How to file a pick request? |
|
I am Facebook hack I am new Facebook account hack karthe |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#54804 was a late pick into 0.83 following RC feedback, but was insufficiently tested. In #54881, users report failing requests attributed to this code path when performing image uploads.
Functionally revert this change, as this breaks runtime behaviour.
Changelog: [Internal]
Changelog (0.83): [Android][Fixed] - Fix Network error that could occur for
FormDatauploads with binary dataDifferential Revision: D89373824