RNGP - Add support for exclusiveEnterpriseRepository#52378
RNGP - Add support for exclusiveEnterpriseRepository#52378cortinico wants to merge 1 commit intofacebook:mainfrom
exclusiveEnterpriseRepository#52378Conversation
|
This pull request was exported from Phabricator. Differential Revision: D77667573 |
38b6563 to
811862e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77667573 |
811862e to
63cf8bd
Compare
63cf8bd to
c753fa0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77667573 |
c753fa0 to
9d28dbb
Compare
9d28dbb to
d9d9f06
Compare
Summary: Pull Request resolved: facebook#52378 This adds a Gradle property called `exclusiveEnterpriseRepository` that users can set in their `android/gradle.properties` as such: ```diff # Use this property to enable or disable the Hermes JS engine. # If set to false, you will be using JSC instead. hermesEnabled=true +exclusiveEnterpriseRepository=https://my.internal.proxy.net/ ``` This will remove all the existing Maven repositories and only use the internal mirror they have. Changelog: [Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror. Reviewed By: mdvacca Differential Revision: D77667573
|
This pull request was exported from Phabricator. Differential Revision: D77667573 |
d9d9f06 to
974385f
Compare
|
This pull request has been merged in 6cb8dc3. |
|
This pull request was successfully merged by @cortinico in 6cb8dc3 When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #52378 This adds a Gradle property called `exclusiveEnterpriseRepository` that users can set in their `android/gradle.properties` as such: ```diff hermesEnabled=true +exclusiveEnterpriseRepository=https://my.internal.proxy.net/ ``` This will remove all the existing Maven repositories and only use the internal mirror they have. Changelog: [Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror. Reviewed By: mdvacca Differential Revision: D77667573 fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
|
This pull request was successfully merged by @cortinico in 89eff97 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico do we plan on supporting some sort of authentication scheme and credentials for this repository? E.g. expo/expo#26895 |
Good point. We probably should. Did you get anyone asking this using Expo? |
Not yet, but I image some larger companies may use credentials for their proxies |
I'd suggest we add them as soon as we get a request for it. Otherwise we're basically re-implementing the whole Gradle Repository API just for the sake of 'potential users' |
Sounds good to me! |
# Why facebook/react-native#52378 introduced a new gradle property called `exclusiveEnterpriseRepository`, allowing users to remove all the existing Maven repositories and only use the specified internal mirror. We should support customizing it through expo-build-properties # How Add support for setting Android's exclusiveMavenMirror gradle property # Test Plan Added tests and ran prebuild inside sandbox with and without the exclusiveMavenMirror option # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Summary: Pull Request resolved: #52378 This adds a Gradle property called `exclusiveEnterpriseRepository` that users can set in their `android/gradle.properties` as such: ```diff hermesEnabled=true +exclusiveEnterpriseRepository=https://my.internal.proxy.net/ ``` This will remove all the existing Maven repositories and only use the internal mirror they have. Changelog: [Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror. Reviewed By: mdvacca Differential Revision: D77667573 fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
|
This pull request was successfully merged by @cortinico in 58a4c2f When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #52378 This adds a Gradle property called `exclusiveEnterpriseRepository` that users can set in their `android/gradle.properties` as such: ```diff # Use this property to enable or disable the Hermes JS engine. # If set to false, you will be using JSC instead. hermesEnabled=true +exclusiveEnterpriseRepository=https://my.internal.proxy.net/ ``` This will remove all the existing Maven repositories and only use the internal mirror they have. Changelog: [Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror. Reviewed By: mdvacca Differential Revision: D77667573 fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
Summary: Pull Request resolved: #52378 This adds a Gradle property called `exclusiveEnterpriseRepository` that users can set in their `android/gradle.properties` as such: ```diff # Use this property to enable or disable the Hermes JS engine. # If set to false, you will be using JSC instead. hermesEnabled=true +exclusiveEnterpriseRepository=https://my.internal.proxy.net/ ``` This will remove all the existing Maven repositories and only use the internal mirror they have. Changelog: [Android] [Added] - RNGP - Add support for `exclusiveEnterpriseRepository` to specify an internal Maven mirror. Reviewed By: mdvacca Differential Revision: D77667573 fbshipit-source-id: 835004d2ae7aa4e250b6f7a88a41918b573f5bd5
Summary:
This adds a Gradle property called
exclusiveEnterpriseRepositorythat users can set in their
android/gradle.propertiesas such:This will remove all the existing Maven repositories and only use the internal mirror they have.
Changelog:
[Android] [Added] - RNGP - Add support for
exclusiveEnterpriseRepositoryto specify an internal Maven mirror.Differential Revision: D77667573