Correctly batch reportMount calls#50090
Closed
rubennorte wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
Summary: Changelog: [internal] I refactored `FabricUIManager` in D54547194 / facebook#43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Differential Revision: D71387374
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71387374 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Mar 18, 2025
Summary: Changelog: [internal] I refactored `FabricUIManager` in D54547194 / facebook#43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374
Contributor
|
This pull request has been merged in e4d51cd. |
Collaborator
|
This pull request was successfully merged by @rubennorte in e4d51cd When will my fix make it into a release? | How to file a pick request? |
This was referenced Mar 18, 2025
gabrieldonadel
pushed a commit
that referenced
this pull request
Mar 24, 2025
Summary: Pull Request resolved: #50090 Changelog: [internal] I refactored `FabricUIManager` in D54547194 / #43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374 fbshipit-source-id: cad8a3ead2434738325560902cbab817e5d5dde7
Collaborator
|
This pull request was successfully merged by @rubennorte in 14d0dc5 When will my fix make it into a release? | How to file a pick request? |
fabriziocucci
pushed a commit
that referenced
this pull request
Mar 26, 2025
Summary: Pull Request resolved: #50090 Changelog: [internal] I refactored `FabricUIManager` in D54547194 / #43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374 fbshipit-source-id: cad8a3ead2434738325560902cbab817e5d5dde7
Collaborator
|
This pull request was successfully merged by @rubennorte in 4e4b9ba When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
Summary: Pull Request resolved: #50090 Changelog: [internal] I refactored `FabricUIManager` in D54547194 / #43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374 fbshipit-source-id: cad8a3ead2434738325560902cbab817e5d5dde7
Collaborator
|
This pull request was successfully merged by @rubennorte in eb8c1c3 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 1, 2025
This was referenced Apr 11, 2025
react-native-bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: #50090 Changelog: [internal] I refactored `FabricUIManager` in D54547194 / #43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374 fbshipit-source-id: cad8a3ead2434738325560902cbab817e5d5dde7
Collaborator
|
This pull request was successfully merged by @rubennorte in 2c2c072 When will my fix make it into a release? | How to file a pick request? |
athenayao
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 17, 2025
Summary: Pull Request resolved: facebook#50090 Changelog: [internal] I refactored `FabricUIManager` in D54547194 / facebook#43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it. Reviewed By: javache Differential Revision: D71387374 fbshipit-source-id: cad8a3ead2434738325560902cbab817e5d5dde7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
I refactored
FabricUIManagerin D54547194 / #43337 and accidentally removed setting this flag to avoid scheduling redundant tasks in the UI thread to report mount. This fixes it.Differential Revision: D71387374