[Fabric] iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false#50049
Conversation
…n even though value prop is hardcoded to false
|
This doesn't seem to be the correct fix. We can expect that after |
@javache |
|
Ah, I assumed |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
packages/react-native/React/Fabric/Mounting/ComponentViews/Switch/RCTSwitchComponentView.mm
Outdated
Show resolved
Hide resolved
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for applying the feedback!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in a802be0. |
|
This pull request was successfully merged by @zhongwuzw in a802be0 When will my fix make it into a release? | How to file a pick request? |
…ough value prop is hardcoded to false (#50049) Summary: Fixes #50026 ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false Pull Request resolved: #50049 Test Plan: Repro please see #50026. Reviewed By: javache Differential Revision: D71307864 Pulled By: cipolleschi fbshipit-source-id: 57238296842229cf2f23a3f44134f43e27b54609
|
This pull request was successfully merged by @zhongwuzw in 8d42fc4 When will my fix make it into a release? | How to file a pick request? |
…ough value prop is hardcoded to false (#50049) Summary: Fixes #50026 ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false Pull Request resolved: #50049 Test Plan: Repro please see #50026. Reviewed By: javache Differential Revision: D71307864 Pulled By: cipolleschi fbshipit-source-id: 57238296842229cf2f23a3f44134f43e27b54609
|
This pull request was successfully merged by @zhongwuzw in 4ec5e99 When will my fix make it into a release? | How to file a pick request? |
…ough value prop is hardcoded to false (#50049) Summary: Fixes #50026 ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false Pull Request resolved: #50049 Test Plan: Repro please see #50026. Reviewed By: javache Differential Revision: D71307864 Pulled By: cipolleschi fbshipit-source-id: 57238296842229cf2f23a3f44134f43e27b54609
|
This pull request was successfully merged by @zhongwuzw in 78d6092 When will my fix make it into a release? | How to file a pick request? |
Summary:
Fixes #50026
Changelog:
[IOS] [FIXED] - [Fabric] iOS: Fixes Switch component incorrectly renders as toggled on even though value prop is hardcoded to false
Test Plan:
Repro please see #50026.