[iOS] Fixes TextInput crashes when any text is entered while running as iOS app on apple silicon mac by zhongwuzw · Pull Request #49320 · facebook/react-native

zhongwuzw · 2025-02-11T07:40:37Z

Summary:

Fixes #48544. We can make RCTWeakEventEmitterWrapper to subclass NSDictionary that Textinput supports encode it.

System allowed classes are:

Allowed classes are:
 {(
    "'NSMorphology' (0x20088b6d8) [/System/Library/Frameworks/Foundation.framework]",
    "'NSString' (0x2003f4738) [/System/Library/Frameworks/Foundation.framework]",
    "'NSInflectionRule' (0x20088d348) [/System/Library/Frameworks/Foundation.framework]",
    "'UIColor' (0x2006c0520) [/System/iOSSupport/System/Library/PrivateFrameworks/UIKitCore.framework]",
    "'NSTextAttachment' (0x20042af98) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSShadow' (0x20042ae30) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSTextEncapsulation' (0x200897e50) [/System/Library/Frameworks/CoreText.framework]",
    "'NSTextAlternatives' (0x20042af70) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSFont' (0x20042a9f8) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSAttributedString' (0x2003f3838) [/System/Library/Frameworks/Foundation.framework]",
    "'NSData' (0x2003ed528) [/System/Library/Frameworks/CoreFoundation.framework]",
    "'NSURL' (0x2003ed938) [/System/Library/Frameworks/CoreFoundation.framework]",
    "'NSAdaptiveImageGlyph' (0x2008ae538) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSNumber' (0x2003f4238) [/System/Library/Frameworks/Foundation.framework]",
    "'NSParagraphStyle' (0x20042ad40) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSDictionary' (0x2003ed5a0) [/System/Library/Frameworks/CoreFoundation.framework]",
    "'UIFont' (0x20042c668) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSColor' (0x200412350) [/System/Library/Frameworks/AppKit.framework]",
    "'NSGlyphInfo' (0x20042aa98) [/System/Library/PrivateFrameworks/UIFoundation.framework]",
    "'NSArray' (0x2003ed460) [/System/Library/Frameworks/CoreFoundation.framework]",
    "'NSPresentationIntent' (0x20088da28) [/System/Library/Frameworks/Foundation.framework]"
)}

Changelog:

[IOS] [FIXED] - Fixes TextInput crashes when any text is entered while running as iOS app on apple silicon mac

Test Plan:

Run RNTester on apple silicon mac, and entered some text in textinput, no crash occured. Also, verified that the caret was not jumping around, thus preserving the original fix.

Screen.Recording.2025-02-21.at.10.53.33.mov

…as iOS app on apple silicon mac

javache · 2025-02-11T11:25:28Z

This seems really hacky, and is likely to still break. The closest option here would be NSData with a custom deallocator function I think.

zhongwuzw · 2025-02-12T13:17:10Z

This seems really hacky, and is likely to still break. The closest option here would be NSData with a custom deallocator function I think.

@javache Thanks for your review, can you explain more? you mean we should make RCTWeakEventEmitterWrapper subclass NSData?

facebook-github-bot · 2025-02-21T10:55:30Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

javache · 2025-02-21T11:27:38Z

NSData is a class cluster, we shouldn't subclass it. This will likely still fail if UIKit tries to serialize this.

javache · 2025-02-21T11:36:37Z

I think we should try [NSData initWithBytesNoCopy:length:deallocator:]

Something like?

auto ptr = new std::weak_ptr<const EventEmitter>(eventEmitter);
NSData *data = [NSData alloc] initWithBytesNoCopy:ptr length:sizeof(ptr) deallocator:^(void *, NSUInteger) { delete ptr; }];

cipolleschi · 2025-02-21T12:07:37Z

@javache how do we reconstruct the eventEmitter from the NSData, then?

javache · 2025-02-21T12:11:22Z

Quick sample here: https://gist.github.com/javache/6c5e6f6cbeda31bb033f4ee92678ce8b

zhongwuzw · 2025-02-21T12:24:01Z

Quick sample here: gist.github.com/javache/6c5e6f6cbeda31bb033f4ee92678ce8b

@javache How to compare the eventEmitter？ If we don't subclass NSData , seems it's just compare the bytes pointer. The compare method called by the system when compare the attributes.

react-native/packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.mm

Lines 38 to 48 in f5837bf

    
           - (BOOL)isEqual:(id)object 
        
           { 
        
             // We consider the underlying EventEmitter as the identity 
        
             if (![object isKindOfClass:[self class]]) { 
        
               return NO; 
        
             } 
        
             auto thisEventEmitter = [self eventEmitter]; 
        
             auto otherEventEmitter = [((RCTWeakEventEmitterWrapper *)object) eventEmitter]; 
        
             return thisEventEmitter == otherEventEmitter; 
        
           }

javache · 2025-02-21T12:50:24Z

This would require a bit of a refactor to RCTWeakEventEmitterWrapper and replacing it with 2 utility functions to wrap and unwrap an event emitter with NSData

zhongwuzw · 2025-02-21T13:05:12Z

I mean If we use NSData directly and store it in the attributes, when Core Text compared all attributes, it would call isEqualToData, seems no chance we can compare the two eventemitter, they are just compare the bytes pointer of NSData.

https://gist.github.com/javache/6c5e6f6cbeda31bb033f4ee92678ce8b#file-test-mm-L24

zhongwuzw · 2025-03-04T02:04:03Z

@javache Hi, friendly ping, can we please move on this issue?

PS. It's a 100% crash and I see many people added +1 in the issue #48544 (comment).

javache · 2025-03-06T16:24:36Z

Sorry for the delay! Just tried with isEqual, and this does seem to work correctly

https://gist.github.com/javache/0b7070e50fe7174814c26476c01b7558

Copies of shared_ptr are identical buffers of data, they're just two pointers to a shared piece of memory

zhongwuzw · 2025-03-07T03:26:00Z

@javache Hi, I applied the review feedback. Please review it. It's not crash but seems has many error logs like below, whatever, we can try it :) :

...rer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.h

facebook-github-bot · 2025-03-10T17:03:15Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

javache · 2025-03-10T17:25:16Z

The logs are a bit suspicious, but let's try this out. Please for your test plan, validate that nested text clicks still work.

...rer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.h

facebook-github-bot · 2025-03-11T10:08:51Z

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

zhongwuzw · 2025-03-11T10:17:21Z

The logs are a bit suspicious, but let's try this out. Please for your test plan, validate that nested text clicks still work.

ok. seems we should use fantom? Maybe I need to learn how to write test and do it in a later PR?

facebook-github-bot · 2025-03-11T13:10:21Z

@cipolleschi merged this pull request in 8d7aca3.

… app on apple silicon mac (#49320) Summary: Fixes #48544. We can make `RCTWeakEventEmitterWrapper` to subclass `NSDictionary` that Textinput supports encode it. System allowed classes are: ``` Allowed classes are: {( "'NSMorphology' (0x20088b6d8) [/System/Library/Frameworks/Foundation.framework]", "'NSString' (0x2003f4738) [/System/Library/Frameworks/Foundation.framework]", "'NSInflectionRule' (0x20088d348) [/System/Library/Frameworks/Foundation.framework]", "'UIColor' (0x2006c0520) [/System/iOSSupport/System/Library/PrivateFrameworks/UIKitCore.framework]", "'NSTextAttachment' (0x20042af98) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSShadow' (0x20042ae30) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSTextEncapsulation' (0x200897e50) [/System/Library/Frameworks/CoreText.framework]", "'NSTextAlternatives' (0x20042af70) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSFont' (0x20042a9f8) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSAttributedString' (0x2003f3838) [/System/Library/Frameworks/Foundation.framework]", "'NSData' (0x2003ed528) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSURL' (0x2003ed938) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSAdaptiveImageGlyph' (0x2008ae538) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSNumber' (0x2003f4238) [/System/Library/Frameworks/Foundation.framework]", "'NSParagraphStyle' (0x20042ad40) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSDictionary' (0x2003ed5a0) [/System/Library/Frameworks/CoreFoundation.framework]", "'UIFont' (0x20042c668) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSColor' (0x200412350) [/System/Library/Frameworks/AppKit.framework]", "'NSGlyphInfo' (0x20042aa98) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSArray' (0x2003ed460) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSPresentationIntent' (0x20088da28) [/System/Library/Frameworks/Foundation.framework]" )} ``` ## Changelog: [IOS] [FIXED] - Fixes TextInput crashes when any text is entered while running as iOS app on apple silicon mac Pull Request resolved: #49320 Test Plan: Run RNTester on apple silicon mac, and entered some text in textinput, no crash occured. Also, verified that the caret was not jumping around, thus preserving the original fix. https://github.com/user-attachments/assets/6304f6e7-c663-4351-ace8-ab1842ee545f Reviewed By: javache Differential Revision: D69981500 Pulled By: cipolleschi fbshipit-source-id: 2af9b280e42f621446efda9b101af50525e8fef7

react-native-bot · 2025-03-11T14:23:43Z

This pull request was successfully merged by @zhongwuzw in 1545169

^{When will my fix make it into a release? | How to file a pick request?}

… app on apple silicon mac (#49320) Summary: Fixes #48544. We can make `RCTWeakEventEmitterWrapper` to subclass `NSDictionary` that Textinput supports encode it. System allowed classes are: ``` Allowed classes are: {( "'NSMorphology' (0x20088b6d8) [/System/Library/Frameworks/Foundation.framework]", "'NSString' (0x2003f4738) [/System/Library/Frameworks/Foundation.framework]", "'NSInflectionRule' (0x20088d348) [/System/Library/Frameworks/Foundation.framework]", "'UIColor' (0x2006c0520) [/System/iOSSupport/System/Library/PrivateFrameworks/UIKitCore.framework]", "'NSTextAttachment' (0x20042af98) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSShadow' (0x20042ae30) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSTextEncapsulation' (0x200897e50) [/System/Library/Frameworks/CoreText.framework]", "'NSTextAlternatives' (0x20042af70) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSFont' (0x20042a9f8) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSAttributedString' (0x2003f3838) [/System/Library/Frameworks/Foundation.framework]", "'NSData' (0x2003ed528) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSURL' (0x2003ed938) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSAdaptiveImageGlyph' (0x2008ae538) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSNumber' (0x2003f4238) [/System/Library/Frameworks/Foundation.framework]", "'NSParagraphStyle' (0x20042ad40) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSDictionary' (0x2003ed5a0) [/System/Library/Frameworks/CoreFoundation.framework]", "'UIFont' (0x20042c668) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSColor' (0x200412350) [/System/Library/Frameworks/AppKit.framework]", "'NSGlyphInfo' (0x20042aa98) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSArray' (0x2003ed460) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSPresentationIntent' (0x20088da28) [/System/Library/Frameworks/Foundation.framework]" )} ``` ## Changelog: [IOS] [FIXED] - Fixes TextInput crashes when any text is entered while running as iOS app on apple silicon mac Pull Request resolved: #49320 Test Plan: Run RNTester on apple silicon mac, and entered some text in textinput, no crash occured. Also, verified that the caret was not jumping around, thus preserving the original fix. https://github.com/user-attachments/assets/6304f6e7-c663-4351-ace8-ab1842ee545f Reviewed By: javache Differential Revision: D69981500 Pulled By: cipolleschi fbshipit-source-id: 2af9b280e42f621446efda9b101af50525e8fef7

react-native-bot · 2025-03-11T14:24:03Z

This pull request was successfully merged by @zhongwuzw in adc5c3a

^{When will my fix make it into a release? | How to file a pick request?}

react-native-bot · 2025-03-11T14:24:11Z

This pull request was successfully merged by @zhongwuzw in 282cdc9

^{When will my fix make it into a release? | How to file a pick request?}

… app on apple silicon mac (#49320) Summary: Fixes #48544. We can make `RCTWeakEventEmitterWrapper` to subclass `NSDictionary` that Textinput supports encode it. System allowed classes are: ``` Allowed classes are: {( "'NSMorphology' (0x20088b6d8) [/System/Library/Frameworks/Foundation.framework]", "'NSString' (0x2003f4738) [/System/Library/Frameworks/Foundation.framework]", "'NSInflectionRule' (0x20088d348) [/System/Library/Frameworks/Foundation.framework]", "'UIColor' (0x2006c0520) [/System/iOSSupport/System/Library/PrivateFrameworks/UIKitCore.framework]", "'NSTextAttachment' (0x20042af98) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSShadow' (0x20042ae30) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSTextEncapsulation' (0x200897e50) [/System/Library/Frameworks/CoreText.framework]", "'NSTextAlternatives' (0x20042af70) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSFont' (0x20042a9f8) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSAttributedString' (0x2003f3838) [/System/Library/Frameworks/Foundation.framework]", "'NSData' (0x2003ed528) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSURL' (0x2003ed938) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSAdaptiveImageGlyph' (0x2008ae538) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSNumber' (0x2003f4238) [/System/Library/Frameworks/Foundation.framework]", "'NSParagraphStyle' (0x20042ad40) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSDictionary' (0x2003ed5a0) [/System/Library/Frameworks/CoreFoundation.framework]", "'UIFont' (0x20042c668) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSColor' (0x200412350) [/System/Library/Frameworks/AppKit.framework]", "'NSGlyphInfo' (0x20042aa98) [/System/Library/PrivateFrameworks/UIFoundation.framework]", "'NSArray' (0x2003ed460) [/System/Library/Frameworks/CoreFoundation.framework]", "'NSPresentationIntent' (0x20088da28) [/System/Library/Frameworks/Foundation.framework]" )} ``` ## Changelog: [IOS] [FIXED] - Fixes TextInput crashes when any text is entered while running as iOS app on apple silicon mac Pull Request resolved: #49320 Test Plan: Run RNTester on apple silicon mac, and entered some text in textinput, no crash occured. Also, verified that the caret was not jumping around, thus preserving the original fix. https://github.com/user-attachments/assets/6304f6e7-c663-4351-ace8-ab1842ee545f Reviewed By: javache Differential Revision: D69981500 Pulled By: cipolleschi fbshipit-source-id: 2af9b280e42f621446efda9b101af50525e8fef7

react-native-bot · 2025-03-11T14:24:32Z

This pull request was successfully merged by @zhongwuzw in e2b081e

^{When will my fix make it into a release? | How to file a pick request?}

[iOS] Fixes TextInput crashes when any text is entered while running …

4dee703

…as iOS app on apple silicon mac

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 11, 2025

zhongwuzw mentioned this pull request Feb 14, 2025

TextInput crashes when any text is entered while running as iOS app on apple silicon mac ("My Mac (Designed for iPhone)" target) #48544

Closed

Subclass NSData

03fea06

Uses NSData wrapper directly

86a7303

zhongwuzw commented Mar 7, 2025

View reviewed changes

...rer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.h Outdated Show resolved Hide resolved

javache reviewed Mar 7, 2025

View reviewed changes

...rer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.h Outdated Show resolved Hide resolved

Use dynamic_cast to check ptr

656f170

zhongwuzw requested a review from javache March 10, 2025 03:14

javache approved these changes Mar 10, 2025

View reviewed changes

...rer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.h Outdated Show resolved Hide resolved

Fix method name

fbbacb8

facebook-github-bot closed this in 8d7aca3 Mar 11, 2025

facebook-github-bot added the Merged This PR has been merged. label Mar 11, 2025

cipolleschi mentioned this pull request Mar 19, 2025

[RN][CI][Releases] Remove the v prefix from the version passed by GHA to the script #50130

Merged

This was referenced Apr 1, 2025

[RN][iOS][0.76] Bump folly to fix xcode 16.3 removed traits #50431

Merged

[CI][Windows] Downgrade CMake to 3.31.6 #50459

Merged

This was referenced Apr 11, 2025

[RN][iOS] Do not generate ReactCodegen.podspec for libraries #50646

Merged

[RN][Codegen] Do not generate Apple specific file for Android #50655

Merged

cipolleschi mentioned this pull request Jun 4, 2025

[Local] Fix CI for 0.79-stable #51804

Merged

cipolleschi mentioned this pull request Jun 16, 2025

[RN][Codegen] Backports fix: exclusion of selectively disabled libraries from codegen generation #52040

Merged

cipolleschi mentioned this pull request Oct 20, 2025

[RN]Downgrade CMake to fix CI #54210

Merged

Conversation

zhongwuzw commented Feb 11, 2025 • edited by cipolleschi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changelog:

Test Plan:

Uh oh!

javache commented Feb 11, 2025

Uh oh!

zhongwuzw commented Feb 12, 2025

Uh oh!

facebook-github-bot commented Feb 21, 2025

Uh oh!

javache commented Feb 21, 2025

Uh oh!

javache commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipolleschi commented Feb 21, 2025

Uh oh!

javache commented Feb 21, 2025

Uh oh!

zhongwuzw commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

javache commented Feb 21, 2025

Uh oh!

zhongwuzw commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhongwuzw commented Mar 4, 2025

Uh oh!

javache commented Mar 6, 2025

Uh oh!

zhongwuzw commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Mar 10, 2025

Uh oh!

javache commented Mar 10, 2025

Uh oh!

Uh oh!

facebook-github-bot commented Mar 11, 2025

Uh oh!

zhongwuzw commented Mar 11, 2025

Uh oh!

facebook-github-bot commented Mar 11, 2025

Uh oh!

react-native-bot commented Mar 11, 2025

Uh oh!

react-native-bot commented Mar 11, 2025

Uh oh!

react-native-bot commented Mar 11, 2025

Uh oh!

react-native-bot commented Mar 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhongwuzw commented Feb 11, 2025 •

edited by cipolleschi

Loading

javache commented Feb 21, 2025 •

edited

Loading

zhongwuzw commented Feb 21, 2025 •

edited

Loading

zhongwuzw commented Feb 21, 2025 •

edited

Loading

zhongwuzw commented Mar 7, 2025 •

edited

Loading