Fix @react-native/popup-menu-android not building for 3rd party developers#49212
Fix @react-native/popup-menu-android not building for 3rd party developers#49212cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D69192874 |
|
This pull request was exported from Phabricator. Differential Revision: D69192874 |
…opers (facebook#49212) Summary: Currently, developers can't use `popup-menu-android` at all because the Gradle file we publish is referencing internal machinery. I'm adding a pre-publish script that manipulates the Gradle. This is the easiest solution without having to do crazy setup inside RNGP or having duplicated version codes around in the monorepo. Fixes facebook#49112 Changelog: [Android] [Fixed] - Fix react-native/popup-menu-android not building for 3rd party developers Reviewed By: cipolleschi Differential Revision: D69192874
c99a40b to
52e4226
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69192874 |
|
This pull request has been merged in e96396b. |
|
This pull request was successfully merged by @cortinico in e96396b When will my fix make it into a release? | How to file a pick request? |
|
@cortinico Hey Cortinico! Is this package ready to be used? When importing it into my project, it is not recognized in RN 0.76 |
The fix is in main. It will have to be cherry-picked in the release branches of the version you're using: https://github.com/reactwg/react-native-releases/#what-is-a-pick-request |
Thanks and done! reactwg/react-native-releases#803 |
…opers (#49212) Summary: Pull Request resolved: #49212 Currently, developers can't use `popup-menu-android` at all because the Gradle file we publish is referencing internal machinery. I'm adding a pre-publish script that manipulates the Gradle. This is the easiest solution without having to do crazy setup inside RNGP or having duplicated version codes around in the monorepo. Fixes #49112 Changelog: [Android] [Fixed] - Fix react-native/popup-menu-android not building for 3rd party developers Reviewed By: cipolleschi Differential Revision: D69192874 fbshipit-source-id: 9f9e8a0a6e76308e598a09f4c70dbc659c238b00
|
This pull request was successfully merged by @cortinico in ac637ff When will my fix make it into a release? | How to file a pick request? |
Summary:
Currently, developers can't use
popup-menu-androidat all because the Gradle file we publish is referencinginternal machinery.
I'm adding a pre-publish script that manipulates the Gradle. This is the easiest solution without having to do
crazy setup inside RNGP or having duplicated version codes around in the monorepo.
Fixes #49112
Changelog:
[Android] [Fixed] - Fix react-native/popup-menu-android not building for 3rd party developers
Differential Revision: D69192874