[iOS] Paper: TextInput maxLength is not working in old arch#48126
Closed
mateoguzmana wants to merge 1 commit intofacebook:mainfrom
Closed
[iOS] Paper: TextInput maxLength is not working in old arch#48126mateoguzmana wants to merge 1 commit intofacebook:mainfrom
maxLength is not working in old arch#48126mateoguzmana wants to merge 1 commit intofacebook:mainfrom
Conversation
maxLength is not working
maxLength is not workingmaxLength is not working
maxLength is not workingmaxLength is not working in old arch
cipolleschi
approved these changes
Dec 10, 2024
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 9ecf290. |
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 9ecf290 When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
Jan 8, 2025
Summary: Fixes #47563 It seems like a regression from #45401, where it was aimed to fix `onChangeText` being called multiple times when changing the text programmatically in an input with the `multiline` prop set as true. This PR reverts that partially, as the `maxLength` check is not being evaluated correctly before setting the text. Not reverting it completely as when removing the second part of the fix, the `onChangeText` gets called multiple times again. ## Changelog: [IOS] [FIXED] - Fixing TextInput `maxLength` not working in old arch Pull Request resolved: #48126 Test Plan: The issue could be reproduced in the rn-tester. See my videos with the before and after the fix. <details> <summary>Before:</summary> https://github.com/user-attachments/assets/86fd67eb-fc14-469a-a5f8-8e83b49f857c </details> <details> <summary>After:</summary> https://github.com/user-attachments/assets/368383b1-c1bd-4e0b-ac44-c78022462fa0 </details> Reviewed By: cortinico Differential Revision: D67025182 Pulled By: cipolleschi fbshipit-source-id: 720c400eef362618106ae434aef421c7529214fe
robhogan
pushed a commit
that referenced
this pull request
Jan 15, 2025
Summary: Fixes #47563 It seems like a regression from #45401, where it was aimed to fix `onChangeText` being called multiple times when changing the text programmatically in an input with the `multiline` prop set as true. This PR reverts that partially, as the `maxLength` check is not being evaluated correctly before setting the text. Not reverting it completely as when removing the second part of the fix, the `onChangeText` gets called multiple times again. ## Changelog: [IOS] [FIXED] - Fixing TextInput `maxLength` not working in old arch Pull Request resolved: #48126 Test Plan: The issue could be reproduced in the rn-tester. See my videos with the before and after the fix. <details> <summary>Before:</summary> https://github.com/user-attachments/assets/86fd67eb-fc14-469a-a5f8-8e83b49f857c </details> <details> <summary>After:</summary> https://github.com/user-attachments/assets/368383b1-c1bd-4e0b-ac44-c78022462fa0 </details> Reviewed By: cortinico Differential Revision: D67025182 Pulled By: cipolleschi fbshipit-source-id: 720c400eef362618106ae434aef421c7529214fe
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #47563
It seems like a regression from #45401, where it was aimed to fix
onChangeTextbeing called multiple times when changing the text programmatically in an input with themultilineprop set as true.This PR reverts that partially, as the
maxLengthcheck is not being evaluated correctly before setting the text. Not reverting it completely as when removing the second part of the fix, theonChangeTextgets called multiple times again.Changelog:
[IOS] [FIXED] - Fixing TextInput
maxLengthnot working in old archTest Plan:
The issue could be reproduced in the rn-tester. See my videos with the before and after the fix.
Before:
Screen.Recording.2024-12-05.at.18.55.39.mov
After:
Screen.Recording.2024-12-05.at.18.53.27.mov