[RN][Windows] Allow downgrading CMake to build hermesc on Windows#47867
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[RN][Windows] Allow downgrading CMake to build hermesc on Windows#47867cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 0eb9472. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 0eb9472 When will my fix make it into a release? | How to file a pick request? |
blakef
pushed a commit
that referenced
this pull request
Nov 21, 2024
Summary: CI is failing to build HermesC on windows due to a version mismatch of the CMake already installed ## Changelog: [Internal] - Fix Windows CI for HermesC Pull Request resolved: #47867 Test Plan: GHA Reviewed By: robhogan Differential Revision: D66292617 Pulled By: cipolleschi fbshipit-source-id: 5e8f4f45e33fbdd9ff163b4e8a09cb98d4366dc7
Collaborator
|
This pull request was successfully merged by @cipolleschi in d8b727c When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
CI is failing to build HermesC on windows due to a version mismatch of the CMake already installed
Changelog:
[Internal] - Fix Windows CI for HermesC
Test Plan:
GHA