Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
a8969a3 to
4b3e626
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
Base commit: ea85b31 |
4b3e626 to
e052257
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
Summary: Fixes running the `build.sh` script for `react-native-codegen` when on [EdenFS](https://github.com/facebook/sapling). This would previously fail due a filesystem "unable to copy extended attributes" error. This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating `RNTester` builds. NOTE: **This is temporary**. The change from `mv` to `cp -R` makes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ move `react-native-codegen` to the [shared monorepo build setup](facebook#38718), and 2/ drop this step entirely from the Android Gradle build. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D49468891
e052257 to
ecb41e9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
ecb41e9 to
bcb5077
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49468891 |
Contributor
|
This pull request has been merged in eaec4f7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes running the
build.shscript forreact-native-codegenwhen on EdenFS. This would previously fail due a filesystem "unable to copy extended attributes" error.This only affects development within the React Native monorepo. Practically, this equates to a workflow improvement for Meta engineers when creating
RNTesterbuilds.Note
This is temporary. The change from
mvtocp -Rmakes this script more expensive, which will make Android builds via Gradle take slightly longer. I have a WIP cleanup planned which will 1/ movereact-native-codegento the shared monorepo build setup, and 2/ drop this step entirely from the Android Gradle build.Changelog: [Internal]
Differential Revision: D49468891