Fix the setup to allow the build-from-source on host projects#36702
Fix the setup to allow the build-from-source on host projects#36702cortinico wants to merge 1 commit intofacebook:mainfrom
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D44502428 |
hoxyq
left a comment
There was a problem hiding this comment.
Looks good to me, but I am not an expert on Gradle.
Any plans on moving tasks from <root>/build.gradle.kts to <root>/packages/react-native/build.gradle.kts and adding proxy-ing?
Base commit: 8eb28e7 |
|
This pull request was exported from Phabricator. Differential Revision: D44502428 |
095109d to
e63f604
Compare
…ok#36702) Summary: Pull Request resolved: facebook#36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 4e351b45b13370e5c082004bc6567007c57e6ee7
|
This pull request was exported from Phabricator. Differential Revision: D44502428 |
e63f604 to
9af9c50
Compare
|
This pull request has been merged in fec5658. |
Summary: Pull Request resolved: #36702 With the monorepo changes we broke the build from source for users. This fixes it so that folks can just follow the guide: https://reactnative.dev/contributing/how-to-build-from-source Changelog: [Android] [Fixed] - Fix the setup to allow the build-from-source on host projects Reviewed By: cipolleschi Differential Revision: D44502428 fbshipit-source-id: 3ad8fb114f5e2f7ffdf6fffa617ceaa45334f5f3
@hoxyq Nope I don't think we'll be doing this for now, as those will be exposed to users, and I'm trying to keep the |
|
@cortinico do we need to cherry-pick this in 0.72 branch? |
|
Yup this needs to be backported 👍 |
Summary:
With the monorepo changes we broke the build from source for users.
This fixes it so that folks can just follow the guide:
https://reactnative.dev/contributing/how-to-build-from-source
Changelog:
[Android] [Fixed] - Fix the setup to allow the build-from-source on host projects
Differential Revision: D44502428