Revert "Fix Deadlock in RCTi18nUtil (iOS) (#31032)"#32574
Closed
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Closed
Revert "Fix Deadlock in RCTi18nUtil (iOS) (#31032)"#32574Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Saadnajmi wants to merge 1 commit intofacebook:mainfrom
Conversation
This reverts commit fcead14.
Contributor
|
@GijsWeterings has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Base commit: b27a83b |
Base commit: b27a83b |
Contributor
|
@GijsWeterings merged this pull request in 70ddf46. |
lunaleaps
pushed a commit
that referenced
this pull request
Nov 30, 2021
Summary: This reverts commit fcead14. This should close #32509 . There was a bug where il8nManager.forceRTL() wouldn't work on app launch, and required an app restart. That was caused by an earlier change (#31032) which should not be necessary (the deadlock it was attempting to fix was actually caused by separate code). ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fixed bug where forceRTL did not work on app launch Pull Request resolved: #32574 Test Plan: Simple revert back to previously working code. Reviewed By: RSNara Differential Revision: D32315034 Pulled By: GijsWeterings fbshipit-source-id: dae6c1f0a2481e53f2f1e80f1ac083947681ef99
mmmoussa
pushed a commit
to mmmoussa/react-native
that referenced
this pull request
Dec 6, 2021
…#32574) Summary: This reverts commit fcead14. This should close facebook#32509 . There was a bug where il8nManager.forceRTL() wouldn't work on app launch, and required an app restart. That was caused by an earlier change (facebook#31032) which should not be necessary (the deadlock it was attempting to fix was actually caused by separate code). ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fixed bug where forceRTL did not work on app launch Pull Request resolved: facebook#32574 Test Plan: Simple revert back to previously working code. Reviewed By: RSNara Differential Revision: D32315034 Pulled By: GijsWeterings fbshipit-source-id: dae6c1f0a2481e53f2f1e80f1ac083947681ef99
lunaleaps
pushed a commit
that referenced
this pull request
Dec 7, 2021
Summary: This reverts commit fcead14. This should close #32509 . There was a bug where il8nManager.forceRTL() wouldn't work on app launch, and required an app restart. That was caused by an earlier change (#31032) which should not be necessary (the deadlock it was attempting to fix was actually caused by separate code). ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fixed bug where forceRTL did not work on app launch Pull Request resolved: #32574 Test Plan: Simple revert back to previously working code. Reviewed By: RSNara Differential Revision: D32315034 Pulled By: GijsWeterings fbshipit-source-id: dae6c1f0a2481e53f2f1e80f1ac083947681ef99 Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts commit fcead14.
This should close #32509 . There was a bug where il8nManager.forceRTL() wouldn't work on app launch, and required an app restart. That was caused by an earlier change (#31032) which should not be necessary (the deadlock it was attempting to fix was actually caused by separate code).
Changelog
[iOS] [Fixed] - Fixed bug where forceRTL did not work on app launch
Test Plan
Simple revert back to previously working code.