Android Test: target SDK 21 instead of 16 by fkgozali · Pull Request #30280 · facebook/react-native

fkgozali · 2020-10-30T05:37:20Z

Summary:
Now that React Native targets minimum SDK of 21, use that SDK level to run test. For some reason the default was previously 16 (I couldn't figure out where this was configured). This fixes the following test failure:

https://app.circleci.com/pipelines/github/facebook/react-native/6937/workflows/d2d365f8-3f5d-453d-af28-68a040fb4188/jobs/174719/parallel-runs/0

Changelog: [Android][Deprecated] Deprecate support of Android API levels 19 and 20.

Reviewed By: JoshuaGross

Differential Revision: D24643610

facebook-github-bot · 2020-10-30T05:37:35Z

This pull request was exported from Phabricator. Differential Revision: D24643610

pull-bot · 2020-10-30T05:43:31Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

	Messages
📖	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`. Details CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖	📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖	📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 22b690b

analysis-bot · 2020-10-30T05:57:16Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 36b0f7d

Summary: Take in the fix from facebook#30273 + force starting adb server before launching AVD. Changelog: [Internal] Differential Revision: D24638504 fbshipit-source-id: 510864cc8beb944abff344f96de182859132060e

Summary: Pull Request resolved: facebook#30280 Now that React Native targets minimum SDK of 21, use that SDK level to run test. For some reason the default was previously 16 (I couldn't figure out where this was configured). This fixes the following test failure: https://app.circleci.com/pipelines/github/facebook/react-native/6937/workflows/d2d365f8-3f5d-453d-af28-68a040fb4188/jobs/174719/parallel-runs/0 To test, using local Docker image: ``` root@d5618d33a37b:/app# buck test ReactAndroid/src/test/... Not using buckd because watchman isn't installed. Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8 Parsing buck files: finished in 2.4 sec Creating action graph: finished in 0.6 sec Building: finished in 36.8 sec (100%) 577/577 jobs, 241 updated Total time: 39.9 sec Testing: finished in 02:19.7 min (167 PASS/0 FAIL) RESULTS FOR //ReactAndroid/src/test/java/com/facebook/react/animated:animated //ReactAndroid/src/test/java/com/facebook/react/bridge:bridge //ReactAndroid/src/test/java/com/facebook/react/devsupport:devsupport //ReactAndroid/src/test/java/com/facebook/react/modules:modules //ReactAndroid/src/test/java/com/facebook/react/packagerconnection:packagerconnection //ReactAndroid/src/test/java/com/facebook/react/uimanager/layoutanimation:layoutanimation //ReactAndroid/src/test/java/com/facebook/react/uimanager:uimanager //ReactAndroid/src/test/java/com/facebook/react/util:util //ReactAndroid/src/test/java/com/facebook/react/views:views //ReactAndroid/src/test/java/com/facebook/react:react PASS 18.3s 7 Passed 0 Skipped 0 Failed com.facebook.react.animated.NativeAnimatedInterpolationTest PASS 32.4s 24 Passed 0 Skipped 0 Failed com.facebook.react.animated.NativeAnimatedNodeTraversalTest PASS 25.2s 4 Passed 0 Skipped 0 Failed com.facebook.react.bridge.BaseJavaModuleTest PASS 1.8s 4 Passed 0 Skipped 0 Failed com.facebook.react.bridge.FallbackJSBundleLoaderTest PASS <100ms 1 Passed 0 Skipped 0 Failed com.facebook.react.bridge.JavaOnlyArrayTest PASS <100ms 2 Passed 0 Skipped 0 Failed com.facebook.react.bridge.JavaScriptModuleRegistryTest PASS 24.7s 10 Passed 0 Skipped 0 Failed com.facebook.react.devsupport.JSDebuggerWebSocketClientTest PASS 16.6s 4 Passed 0 Skipped 0 Failed com.facebook.react.devsupport.MultipartStreamReaderTest PASS 15.4s 5 Passed 0 Skipped 0 Failed com.facebook.react.devsupport.StackTraceHelperTest PASS 26.0s 6 Passed 0 Skipped 0 Failed com.facebook.react.modules.blob.BlobModuleTest PASS 21.6s 5 Passed 0 Skipped 0 Failed com.facebook.react.modules.camera.ImageStoreManagerTest PASS 15.1s 1 Passed 0 Skipped 0 Failed com.facebook.react.modules.clipboard.ClipboardModuleTest PASS 14.4s 5 Passed 0 Skipped 0 Failed com.facebook.react.modules.dialog.DialogModuleTest PASS <100ms 10 Passed 0 Skipped 0 Failed com.facebook.react.modules.network.HeaderUtilTest PASS 7.9s 14 Passed 0 Skipped 0 Failed com.facebook.react.modules.network.NetworkingModuleTest PASS 4.3s 9 Passed 0 Skipped 0 Failed com.facebook.react.modules.network.ProgressiveStringDecoderTest PASS 5.2s 4 Passed 0 Skipped 0 Failed com.facebook.react.modules.network.ReactCookieJarContainerTest PASS 9.0s 2 Passed 0 Skipped 0 Failed com.facebook.react.modules.share.ShareModuleTest PASS 9.3s 6 Passed 0 Skipped 0 Failed com.facebook.react.modules.storage.AsyncStorageModuleTest PASS 6.7s 10 Passed 0 Skipped 0 Failed com.facebook.react.modules.timing.TimingModuleTest PASS 22.2s 9 Passed 0 Skipped 0 Failed com.facebook.react.packagerconnection.JSPackagerClientTest PASS 18.3s 4 Passed 0 Skipped 0 Failed com.facebook.react.uimanager.layoutanimation.InterpolatorTypeTest PASS 16.9s 2 Passed 0 Skipped 0 Failed com.facebook.react.uimanager.BaseViewManagerTest PASS 15.9s 4 Passed 0 Skipped 0 Failed com.facebook.react.uimanager.MatrixMathHelperTest PASS 16.8s 3 Passed 0 Skipped 0 Failed com.facebook.react.uimanager.SimpleViewPropertyTest PASS <100ms 1 Passed 0 Skipped 0 Failed com.facebook.react.util.JSStackTraceTest PASS 19.9s 1 Passed 0 Skipped 0 Failed com.facebook.react.views.image.ImageResizeModeTest PASS 21.5s 4 Passed 0 Skipped 0 Failed com.facebook.react.views.image.ReactImagePropertyTest PASS 22.9s 4 Passed 0 Skipped 0 Failed com.facebook.react.CompositeReactPackageTest PASS 15.9s 2 Passed 0 Skipped 0 Failed com.facebook.react.RootViewTest Updated test logs: buck-out/log/test.log TESTS PASSED ``` Changelog: [Android][Deprecated] Deprecate support of Android API levels 19 and 20. Reviewed By: JoshuaGross Differential Revision: D24643610 fbshipit-source-id: 826f64bb551495b56d1c71a1b44da4587337c7d3

facebook-github-bot · 2020-10-31T00:57:03Z

This pull request was exported from Phabricator. Differential Revision: D24643610

analysis-bot · 2020-10-31T01:21:14Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,505,546	+111,553
android	hermes	armeabi-v7a	7,097,326	+80,113
android	hermes	x86	7,943,688	+111,579
android	hermes	x86_64	7,854,745	+129,054
android	jsc	arm64-v8a	8,970,249	-565,949
android	jsc	armeabi-v7a	8,545,162	-606,064
android	jsc	x86	8,969,893	-430,981
android	jsc	x86_64	9,521,212	-461,372

Base commit: 36b0f7d

react-native-bot · 2020-10-31T19:50:07Z

This pull request was successfully merged by @fkgozali in 7dcecb2.

^{When will my fix make it into a release? | Upcoming Releases}

fkgozali requested review from cpojer and hramos as code owners October 30, 2020 05:37

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 30, 2020

fkgozali added 2 commits October 30, 2020 17:56

Docker android: addressing AVD launch issue

4093c1b

Summary: Take in the fix from facebook#30273 + force starting adb server before launching AVD. Changelog: [Internal] Differential Revision: D24638504 fbshipit-source-id: 510864cc8beb944abff344f96de182859132060e

fkgozali force-pushed the export-D24643610 branch from 1abd014 to 22b690b Compare October 31, 2020 00:57

facebook-github-bot closed this in 7dcecb2 Oct 31, 2020

react-native-bot added the Merged This PR has been merged. label Oct 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android Test: target SDK 21 instead of 16#30280

Android Test: target SDK 21 instead of 16#30280
fkgozali wants to merge 2 commits intofacebook:masterfrom
fkgozali:export-D24643610

fkgozali commented Oct 30, 2020

Uh oh!

facebook-github-bot commented Oct 30, 2020

Uh oh!

pull-bot commented Oct 30, 2020 •

edited

Loading

Uh oh!

analysis-bot commented Oct 30, 2020

Uh oh!

facebook-github-bot commented Oct 31, 2020

Uh oh!

analysis-bot commented Oct 31, 2020

Uh oh!

react-native-bot commented Oct 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fkgozali commented Oct 30, 2020

Uh oh!

facebook-github-bot commented Oct 30, 2020

Uh oh!

pull-bot commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Oct 30, 2020

Uh oh!

facebook-github-bot commented Oct 31, 2020

Uh oh!

analysis-bot commented Oct 31, 2020

Uh oh!

react-native-bot commented Oct 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pull-bot commented Oct 30, 2020 •

edited

Loading