Added instructions for setting up and running the examples within the re...#250
Added instructions for setting up and running the examples within the re...#250jondot wants to merge 2 commits intofacebook:masterfrom jondot:master
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Just signed the CLA. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
good idea. Let's just remove extra spaces and happy to pull it |
|
This good? |
|
Oh sorry, I thought this was an addition to this repo's readme. I don't think we should add more stuff to the getting started tutorial. It should be as small as possible. However, I think this would be a great addition to this repo's readme. https://github.com/facebook/react-native/blob/master/README.md |
|
Sure, I had the dilemma myself since I didn't see any concrete 'getting started' type wording there, I figured it belonged in the |
|
Fixed via #267 |
…_ptr` to match the change in `RCTCxxBridge.mm` made in facebook@71a8944. (facebook#250)
...pository