remove more peculiar web language#12485
Closed
ryanflorence wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
I guess we could ask Håkon Wium Lie if indeed it was unintended to have a set of rules be inherited or not, but this paragraph is a little bit weird 🤷♀️
hramos
approved these changes
Feb 21, 2017
Contributor
hramos
left a comment
There was a problem hiding this comment.
Approving, will come back and land once tests are green (the failures are unrelated to your PR)
Contributor
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
GaborWnuk
pushed a commit
to GaborWnuk/react-native
that referenced
this pull request
Feb 28, 2017
Summary: I guess we could ask Håkon Wium Lie if indeed it was unintended to have a set of rules be inherited or not, but this paragraph is a little bit weird 🤷♀️ Closes facebook#12485 Differential Revision: D4608425 Pulled By: hramos fbshipit-source-id: a346b1e65c9fc7b06634e529c1ef6f9e24794cca
hramos
pushed a commit
that referenced
this pull request
Mar 9, 2017
Summary: I guess we could ask Håkon Wium Lie if indeed it was unintended to have a set of rules be inherited or not, but this paragraph is a little bit weird 🤷♀️ Closes #12485 Differential Revision: D4608425 Pulled By: hramos fbshipit-source-id: a346b1e65c9fc7b06634e529c1ef6f9e24794cca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess we could ask Håkon Wium Lie if indeed it was unintended to have a set of rules be inherited or not, but this paragraph is a little bit weird 🤷♀️