Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.76.2
Choose a base ref
...
head repository: facebook/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.76.3
Choose a head ref
  • 7 commits
  • 39 files changed
  • 5 contributors

Commits on Nov 15, 2024

  1. Fix typo in template action watcher script (#47286)

    Summary:
    Trivial typo - static analysis would have been a good thing.
    
    Changelog: [Internal]
    
    Pull Request resolved: #47286
    
    Test Plan: eyes
    
    Reviewed By: NickGerleman
    
    Differential Revision: D65145600
    
    Pulled By: blakef
    
    fbshipit-source-id: 567ef3637441aa84651dce03f45b80068c5f4290
    blakef committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ac61c14 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. [LOCAL] Bump Podfile.lock

    cipolleschi committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d01d014 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. fix build failure on windows in android (#47641)

    Summary:
    This pull request addresses a CMake configuration issue where an invalid escape character in file paths caused the build process to fail. Specifically, it resolves the issue in the React Native CMake configuration file where the path separator was incorrectly handled, leading to an error in the build system.
    
    the issue is in [This Issue](expo/expo#32955) and [This](expo/expo#32957)
    
    ## Changelog:
    
    <!-- Help reviewers and the release process by writing your own changelog entry.
    
    Pick one each for the category and type tags:
    
    [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
    
    For more details, see:
    https://reactnative.dev/contributing/changelogs-in-pull-requests
    -->
    
    [INTERNAL] [FIXED] - Corrected invalid escape character in CMake path handling
    
    Pull Request resolved: #47641
    
    Test Plan:
    To test the changes, I performed the following steps:
    
    1. Cloned the repository and checked out the `fix-cmake-invalid-escape-character` branch.
    2. Ran the CMake build on a Windows environment where the issue was previously occurring.
    3. Verified that the build process completed successfully without the "invalid character escape" error.
    4. Ensured that the path handling now works correctly in CMake on Windows platforms.
    
    Reviewed By: rshest
    
    Differential Revision: D66073896
    
    Pulled By: cipolleschi
    
    fbshipit-source-id: bd2a71bb00ce5c5509ed403842c995c32f58f91d
    FouadMagdy01 authored and blakef committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    08b8300 View commit details
    Browse the repository at this point in the history
  2. CMake Windows path normalization (#47702)

    Summary:
    Pull Request resolved: #47702
    
    Use `file(TO_CMAKE_PATH` to normalize paths, and normalizing `input_SRC` as it's already a CMake path.
    
    Changelog: [Internal]
    
    Reviewed By: rshest
    
    Differential Revision: D66101321
    
    fbshipit-source-id: e81af40551d2777901f9c7cf9a4175f2bce76ec8
    blakef committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9946838 View commit details
    Browse the repository at this point in the history
  3. Support Windows sdkmanager.bat (#47874)

    Summary:
    Pull Request resolved: #47874
    
    We should be searching for the .bat file on Windows to remain compatible with some user setups.
    
    Changelog: [Android][Fixed] look for sdkmanager.bat
    
    Reviewed By: cipolleschi
    
    Differential Revision: D66295240
    
    fbshipit-source-id: 6b79a9aa40f77ed9c5b3d6ad92b1a62e78159223
    blakef committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e70cad2 View commit details
    Browse the repository at this point in the history
  4. Allow downgrading CMake to build hermesc on Windows (#47867)

    Summary:
    CI is failing to build HermesC on windows due to a version mismatch of the CMake already installed
    
    ## Changelog:
    [Internal] - Fix Windows CI for HermesC
    
    Pull Request resolved: #47867
    
    Test Plan: GHA
    
    Reviewed By: robhogan
    
    Differential Revision: D66292617
    
    Pulled By: cipolleschi
    
    fbshipit-source-id: 5e8f4f45e33fbdd9ff163b4e8a09cb98d4366dc7
    cipolleschi authored and blakef committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d8b727c View commit details
    Browse the repository at this point in the history
  5. Release 0.76.3

    #publish-packages-to-npm&latest
    react-native-bot committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    605e2e4 View commit details
    Browse the repository at this point in the history
Loading