-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Comparing changes
Open a pull request
base repository: facebook/react-native
base: v0.76.2
head repository: facebook/react-native
compare: v0.76.3
- 7 commits
- 39 files changed
- 5 contributors
Commits on Nov 15, 2024
-
Fix typo in template action watcher script (#47286)
Summary: Trivial typo - static analysis would have been a good thing. Changelog: [Internal] Pull Request resolved: #47286 Test Plan: eyes Reviewed By: NickGerleman Differential Revision: D65145600 Pulled By: blakef fbshipit-source-id: 567ef3637441aa84651dce03f45b80068c5f4290
Configuration menu - View commit details
-
Copy full SHA for ac61c14 - Browse repository at this point
Copy the full SHA ac61c14View commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d01d014 - Browse repository at this point
Copy the full SHA d01d014View commit details
Commits on Nov 21, 2024
-
fix build failure on windows in android (#47641)
Summary: This pull request addresses a CMake configuration issue where an invalid escape character in file paths caused the build process to fail. Specifically, it resolves the issue in the React Native CMake configuration file where the path separator was incorrectly handled, leading to an error in the build system. the issue is in [This Issue](expo/expo#32955) and [This](expo/expo#32957) ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [FIXED] - Corrected invalid escape character in CMake path handling Pull Request resolved: #47641 Test Plan: To test the changes, I performed the following steps: 1. Cloned the repository and checked out the `fix-cmake-invalid-escape-character` branch. 2. Ran the CMake build on a Windows environment where the issue was previously occurring. 3. Verified that the build process completed successfully without the "invalid character escape" error. 4. Ensured that the path handling now works correctly in CMake on Windows platforms. Reviewed By: rshest Differential Revision: D66073896 Pulled By: cipolleschi fbshipit-source-id: bd2a71bb00ce5c5509ed403842c995c32f58f91d
Configuration menu - View commit details
-
Copy full SHA for 08b8300 - Browse repository at this point
Copy the full SHA 08b8300View commit details -
CMake Windows path normalization (#47702)
Summary: Pull Request resolved: #47702 Use `file(TO_CMAKE_PATH` to normalize paths, and normalizing `input_SRC` as it's already a CMake path. Changelog: [Internal] Reviewed By: rshest Differential Revision: D66101321 fbshipit-source-id: e81af40551d2777901f9c7cf9a4175f2bce76ec8
Configuration menu - View commit details
-
Copy full SHA for 9946838 - Browse repository at this point
Copy the full SHA 9946838View commit details -
Support Windows sdkmanager.bat (#47874)
Summary: Pull Request resolved: #47874 We should be searching for the .bat file on Windows to remain compatible with some user setups. Changelog: [Android][Fixed] look for sdkmanager.bat Reviewed By: cipolleschi Differential Revision: D66295240 fbshipit-source-id: 6b79a9aa40f77ed9c5b3d6ad92b1a62e78159223
Configuration menu - View commit details
-
Copy full SHA for e70cad2 - Browse repository at this point
Copy the full SHA e70cad2View commit details -
Allow downgrading CMake to build hermesc on Windows (#47867)
Summary: CI is failing to build HermesC on windows due to a version mismatch of the CMake already installed ## Changelog: [Internal] - Fix Windows CI for HermesC Pull Request resolved: #47867 Test Plan: GHA Reviewed By: robhogan Differential Revision: D66292617 Pulled By: cipolleschi fbshipit-source-id: 5e8f4f45e33fbdd9ff163b4e8a09cb98d4366dc7
Configuration menu - View commit details
-
Copy full SHA for d8b727c - Browse repository at this point
Copy the full SHA d8b727cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 605e2e4 - Browse repository at this point
Copy the full SHA 605e2e4View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.76.2...v0.76.3