Warn about deprecated SVG attributes only once#6184
Merged
gaearon merged 1 commit intofacebook:masterfrom Mar 4, 2016
gaearon:fix-svg-warning
Merged
Warn about deprecated SVG attributes only once#6184gaearon merged 1 commit intofacebook:masterfrom gaearon:fix-svg-warning
gaearon merged 1 commit intofacebook:masterfrom
gaearon:fix-svg-warning
Conversation
| warnedSVGAttributes.hasOwnProperty(name) && warnedSVGAttributes[name]) { | ||
| return; | ||
| } | ||
| warnedSVGAttributes[name] = true; |
Contributor
There was a problem hiding this comment.
Not a deal breaker, but seems a bit weird that warnedSVGAttributes gets set to true even if a warning never fired (ie. bailed out in the next three lines). Maybe a few of these lines can be re-arranged to avoid this, maybe not worth the headache.
Contributor
|
Two nits so small I wasn't even sure if I'd bother mentioning them, feel free to ignore if you want. |
This fixes a missing check in #5714
Contributor
|
@gaearon updated the pull request. |
Collaborator
Author
|
I made two changes:
|
Contributor
|
👍 |
gaearon
added a commit
that referenced
this pull request
Mar 4, 2016
Warn about deprecated SVG attributes only once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a missing assignment in #5714 that caused tons of extraneous warnings.
Before
## AfterReviewers: @zpao