[DevTools] Improve type coverage for extension runtime API#35957
Merged
eps1lon merged 2 commits intofacebook:mainfrom Mar 4, 2026
Merged
Conversation
|
Comparing: 9c0323e...980903c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
hoxyq
approved these changes
Mar 4, 2026
Contributor
hoxyq
left a comment
There was a problem hiding this comment.
Nice, please see my comment above, looks like you've accidentally added one change to this commit.
One important detail about browser extension APIs is that only subset of them is available to scripts from different environments: background, content script, main panel one. I can see 2 ways: we either define an API as optional, if it is only available in some environments, or we apply different flow configs for subfolders under react-devtools-extensions.
packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeContext.js
Outdated
Show resolved
Hide resolved
3c1d4f2 to
980903c
Compare
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
…35957) DiffTrain build for [4b568a8](facebook@4b568a8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 7, 2026
…35957) DiffTrain build for [4b568a8](facebook@4b568a8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds types for
chrome.runtime.*andchrome.tabs.*. Types are based of off the version that's shared across browsers. We'll see if we need different versions for chrome and firefox.devtools.panels,storage,permissions, andscriptingare still typed asany. Main interest wasruntimeandtabsto investigate #35954