Turn off enableYieldingBeforePassive in internal test renderers#31863
Merged
jackpope merged 1 commit intofacebook:mainfrom Dec 20, 2024
Merged
Turn off enableYieldingBeforePassive in internal test renderers#31863jackpope merged 1 commit intofacebook:mainfrom
jackpope merged 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: 518d06d26a97df6d4f5b04e529e5018ad35ea936...beb528af812280d81be4f3fb38e15faba5620354 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
approved these changes
Dec 20, 2024
Collaborator
eps1lon
left a comment
There was a problem hiding this comment.
Test failures may be caused by missing an act(). Though these should ideally all already be accompanied by missing act() warnings.
Contributor
Author
|
@eps1lon We can work through the test failures, its definitely possible there are setup or act problems. But we need to prioritize catching up the sync before the holidays. Then we can test turning these back on. |
This was referenced Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31785 turned on
enableYieldingBeforePassivefor the internal test renderer builds. We have some failing tests on the RN side blocking the sync so lets turn these off for now.