Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: react/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 93fc5740
Choose a base ref
...
head repository: react/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fb2177c1
Choose a head ref
  • 7 commits
  • 23 files changed
  • 5 contributors

Commits on Nov 14, 2025

  1. [Compiler] Don't count a setState in the dependency array of the effe… 

    …ct it is called on as a usage (#35134)

Summary:
The validation only allows setState declaration as a usage outside of
the effect.

Another edge case is that if you add the setState being validated in the
dependency array you also make the validation opt out since it counts as
a usage outside of the effect.

Added a bit of logic to consider the effect's deps when creating the
cache for setState usages within the effect

Test Plan:
Added a fixture

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35134).
* #35135
* __->__ #35134
    @jorge-cab
    jorge-cab authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    de97ef9 View commit details
    Browse the repository at this point in the history

  2. [Compiler] Avoid capturing global setStates for no-derived-computatio… 

    …ns lint (#35135)

Summary:
This only matters when enableTreatSetIdentifiersAsStateSetters=true

This pattern is still bad. But Right now the validation can only
recommend to move stuff to "calculate in render"

A global setState should not be moved to render, not even conditionally
and you can't remove state without crossing Component boundaries, which
makes this a different kind of fix.

So while we are only suggesting "calculate in render" as a fix we should
disallow the lint from throwing in this case IMO

Test Plan:
Added a fixture

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35135).
* __->__ #35135
* #35134
    @jorge-cab
    jorge-cab authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    257b033 View commit details
    Browse the repository at this point in the history

  3. [compiler] Allow ref access in callbacks passed to event handler props ( 

    #35062)

## Summary

Fixes #35040. The React compiler incorrectly flags ref access within
event handlers as ref access at render time. For example, this code
would fail to compile with error "Cannot access refs during render":

```tsx
  const onSubmit = async (data) => {
    const file = ref.current?.toFile(); // Incorrectly flagged as error
  };

  <form onSubmit={handleSubmit(onSubmit)}>
```
This is a false positive because any built-in DOM event handler is
guaranteed not to run at render time. This PR only supports built-in
event handlers because there are no guarantees that user-made event
handlers will not run at render time.

## How did you test this change?

I created 4 test fixtures which validate this change:
* allow-ref-access-in-event-handler-wrapper.tsx - Sync handler test
input
* allow-ref-access-in-event-handler-wrapper.expect.md - Sync handler
expected output
* allow-ref-access-in-async-event-handler-wrapper.tsx - Async handler
test input
* allow-ref-access-in-async-event-handler-wrapper.expect.md - Async
handler expected output

All linters and test suites also pass.
    @kolvian
    kolvian authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    21f2824 View commit details
    Browse the repository at this point in the history

  4. [compiler] Repro for false positive mutation of a value derived from … 

    …props (#35139)

Repro from the compiler WG (Thanks Cody!) of a case where the compiler
incorrectly thinks a value is mutable.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35139).
* #35140
* __->__ #35139
    @josephsavona
    josephsavona authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    dbf2538 View commit details
    Browse the repository at this point in the history

  5. [compiler] Fix for inferring props-derived-value as mutable (#35140) 

    Fix for the repro from the previous PR. A `Capture x -> y` effect should
downgrade to `ImmutableCapture` when the source value is maybe-frozen.
MaybeFrozen represents the union of a frozen value with a non-frozen
value.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35140).
* __->__ #35140
* #35139
    @josephsavona
    josephsavona authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    19b769f View commit details
    Browse the repository at this point in the history

  6. [compiler] fix bad rebase from sapling (#35145) 

    ---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35145).
* #35144
* __->__ #35145
    @josephsavona
    josephsavona authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    647e133 View commit details
    Browse the repository at this point in the history

  7. [Flight] Fix pending chunks count for streams & async iterables in DEV ( 

    #35143)

In DEV, we need to prevent the response from being GC'd while there are
still pending chunks for ReadableSteams or pending results for
AsyncIterables.

Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
    @unstubbable @eps1lon
    unstubbable and eps1lon authored Nov 14, 2025
    Configuration menu
    Copy the full SHA
    fb2177c View commit details
    Browse the repository at this point in the history
Loading