Closed
Conversation
Summary: We started using pyrefly init to set up, which required moving the builds out of mypy primer's control. In the process, we accidentally switched the build mode from dev to release; release builds are too slow. It probably won't fix the problem alone since we already tested this, but without this it probably won't work even if any other problems are fixed Reviewed By: rchen152 Differential Revision: D95741090
Summary: Mypy primer is pretty heavyweight, and github CI is underpowered. I was looking at runs from before it started timing out, and realized that a lot of things that take 1-2s to check internally take much longer. I think it's possible that a few projects (e.g. pandas, sympy) might just be too big to type check massively in parallel on a tiny, underpowered server. Working off that assumption, let's try restoring the old "determinism blocklist" - these projects tend to be some of the biggest, just because the things that trigger nondeterminism also make type check expensive. Differential Revision: D95741691
rchen152
approved these changes
Mar 8, 2026
Contributor
rchen152
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Summary: Mypy primer is pretty heavyweight, and github CI is underpowered. I was looking at runs from before it started timing out, and realized that a lot of things that take 1-2s to check internally take much longer. I think it's possible that a few projects (e.g. pandas, sympy) might just be too big to type check massively in parallel on a tiny, underpowered server. Working off that assumption, let's try restoring the old "determinism blocklist" - these projects tend to be some of the biggest, just because the things that trigger nondeterminism also make type check expensive. Reviewed By: rchen152 Differential Revision: D95741691
meta-codesync bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Summary: Mypy primer is pretty heavyweight, and github CI is underpowered. I was looking at runs from before it started timing out, and realized that a lot of things that take 1-2s to check internally take much longer. I think it's possible that a few projects (e.g. pandas, sympy) might just be too big to type check massively in parallel on a tiny, underpowered server. Working off that assumption, let's try restoring the old "determinism blocklist" - these projects tend to be some of the biggest, just because the things that trigger nondeterminism also make type check expensive. Reviewed By: rchen152 Differential Revision: D95741691
|
This pull request has been merged in ee128e8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mypy primer is pretty heavyweight, and github CI is underpowered.
I was looking at runs from before it started timing out, and realized that a lot of things
that take 1-2s to check internally take much longer.
I think it's possible that a few projects (e.g. pandas, sympy) might just be too big to
type check massively in parallel on a tiny, underpowered server.
Working off that assumption, let's try restoring the old "determinism blocklist" - these
projects tend to be some of the biggest, just because the things that trigger nondeterminism
also make type check expensive.
Differential Revision: D95741691