Add failing unittest for reverse relations using self reference#2089
Closed
migeed-z wants to merge 3 commits intofacebook:mainfrom
Closed
Add failing unittest for reverse relations using self reference#2089migeed-z wants to merge 3 commits intofacebook:mainfrom
migeed-z wants to merge 3 commits intofacebook:mainfrom
Conversation
yangdanny97
approved these changes
Jan 13, 2026
Contributor
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This comment has been minimized.
This comment has been minimized.
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
0e0f5e2 to
fa324e5
Compare
This comment has been minimized.
This comment has been minimized.
…rd) (facebook#2087) Summary: Here, we test the related_name keyword which allows us to customize the reverse relation Reviewed By: aleivag Differential Revision: D90517278
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
fa324e5 to
7da0e26
Compare
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
…book#2089) Summary: Pull Request resolved: facebook#2089 Reviewed By: yangdanny97 Differential Revision: D90517772
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Summary: Pull Request resolved: #2089 Reviewed By: yangdanny97 Differential Revision: D90517772 fbshipit-source-id: 18b7cdde484036f2f64e46f447e8c5bdf70c49b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed By: yangdanny97
Differential Revision: D90517772