[lexical-playground] Bug Fix: Allow PagesExtension to be disabled by ActionsPlugin (html & markdown mode)#8444
Merged
etrepum merged 4 commits intofacebook:mainfrom May 1, 2026
Conversation
…ActionsPlugin (html & markdown mode)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zurfyx
approved these changes
May 1, 2026
etrepum
added a commit
to mayrang/lexical
that referenced
this pull request
May 2, 2026
…ActionsPlugin (html & markdown mode) (facebook#8444)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PagesExtension registers transforms to ensure that all editor content is wrapped in pages, and ActionsPlugin registers a transform to ensure that the RootNode has exactly one CodeNode child. These are incompatible, so the easiest solution is to be able to disable the PagesExtension while the ActionsPlugin wants exclusive control over the editor.
Probably a better way to do ActionsPlugin would be to have a separate editor altogether to view the state as html or markdown, but this is the minimal fix
Closes #8443
Test plan
New e2e test covering the toggle of html mode while pages is active