Skip to content

[lexical-playground] Feature: HTML conversion button#8379

Merged
etrepum merged 5 commits intofacebook:mainfrom
levensta:html-conversion-button
Apr 22, 2026
Merged

[lexical-playground] Feature: HTML conversion button#8379
etrepum merged 5 commits intofacebook:mainfrom
levensta:html-conversion-button

Conversation

@levensta
Copy link
Copy Markdown
Contributor

Description

Here are some minor UI improvements to the lexical-playground:

  • The Markdown mode button now has an active state.
  • The settings block can be scrolled, as not all buttons are visible at small viewport, especially with the DevTools panel open at the bottom

I also added a button for converting to and from HTML, similar to Markdown. Unlike the "export DOM" button in the "debug view" panel, this mode clearly demonstrates how serialization to and from HTML works, enabling debugging of exportDOM/importDOM operations and providing a new way to write tests.

Test plan

Before

Screen.Recording.2026-04-21.at.02.22.24.mov

After

Screen.Recording.2026-04-21.at.02.21.03.mov

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Apr 21, 2026 10:29pm
lexical-playground Ready Ready Preview, Comment Apr 21, 2026 10:29pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2026
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Apr 21, 2026
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these look like positive changes, but maybe since it enables adding tests we should write a test or two to confirm that it does the expected thing (convert to html and then convert back from html). We should probably make some sort of change while it's in html view so we can confirm that it's the actual import.

Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea but we probably want to integrate something like prettier in here so that it's more usable. The node-state-style example does something like that for its html view

await toggleItalic(page);
await insertDateTime(page);

const expectedViewHtml = `<h1 class="PlaygroundEditorTheme__h1" dir="auto">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use the html template string here?

Suggested change
const expectedViewHtml = `<h1 class="PlaygroundEditorTheme__h1" dir="auto">
const expectedViewHtml = html`<h1 class="PlaygroundEditorTheme__h1" dir="auto">

@etrepum etrepum added this pull request to the merge queue Apr 22, 2026
Merged via the queue into facebook:main with commit 4a43cb0 Apr 22, 2026
44 checks passed
@levensta
Copy link
Copy Markdown
Contributor Author

I think this is a great idea but we probably want to integrate something like prettier in here so that it's more usable. The node-state-style example does something like that for its html view

We could automatically run Prettier when switching to HTML mode, but since text elements with the inline style white-space: "pre-wrap"; are sensitive to whitespace during re-import, we'll need to add the following settings:

{
  htmlWhitespaceSensitivity: 'css',
  printWidth: Number.MAX_SAFE_INTEGER
}

It will look like this. It's not very convenient, but it's better than cramming everything into a single line

image

Another question is which specific Prettier to run. I could try running the Prettier that’s already in the CodeActionPlugin
https://github.com/facebook/lexical/blob/main/packages/lexical-playground/src/plugins/CodeActionMenuPlugin/components/PrettierButton/index.tsx
Probably it'll have to handle using the React context.

Or run it as a separate instance within the current ActionsPlugin. But then we'll have to set the same Prettier settings in both places so that the result is consistent

@etrepum
Copy link
Copy Markdown
Collaborator

etrepum commented Apr 22, 2026

We can also normalize the html a bit first to make it less sensitive to whitespace and export fewer theme classes

@levensta
Copy link
Copy Markdown
Contributor Author

levensta commented Apr 22, 2026

If this is done via DOMExtension, it will mislead users, as it may appear to be a original export of built-in nodes

@etrepum
Copy link
Copy Markdown
Collaborator

etrepum commented Apr 22, 2026

Well if it was used in a normal way it would affect all exports, unless it was dispatching based on some render context that was only set for the html view

levensta added a commit to levensta/lexical that referenced this pull request Apr 24, 2026
commit 5d1bc33
Author: Sathvik Veerapaneni <98241593+Sathvik-Chowdary-Veerapaneni@users.noreply.github.com>
Date:   Thu Apr 23 13:12:21 2026 -0400

    [lexical-list] Bug Fix: Merge nested list into parent <li> during HTML export (facebook#8313)

    Co-authored-by: Bob Ippolito <bob@redivi.com>

commit 2c37dc2
Author: Bob Ippolito <bob@redivi.com>
Date:   Thu Apr 23 07:14:14 2026 -0700

    [lexical-clipboard][lexical-rich-text][lexical-plain-text] Bug Fix: Drag-and-drop within the same block (facebook#8373)

    Co-authored-by: Claude <noreply@anthropic.com>

commit ca2aa31
Author: Bob Ippolito <bob@redivi.com>
Date:   Thu Apr 23 07:12:43 2026 -0700

    [lexical][lexical-utils][lexical-list] Bug Fix: Clean up and test $insertNodeToNearestRootAtCaret edge cases (facebook#8384)

commit 207648e
Author: Bob Ippolito <bob@redivi.com>
Date:   Thu Apr 23 07:11:52 2026 -0700

    [lexical-html][lexical-playground] Feature: Implement a well-defined ordering for DOMRenderExtension overrides and add $decorateDOM (facebook#8368)

commit 1ca42f1
Author: Agyei Holy <agyeiholy978@gmail.com>
Date:   Wed Apr 22 15:39:37 2026 -0500

    [lexical][lexical-code-core][lexical-list][lexical-table][lexical-yjs] Refactor: make runtime style updates CSP-safe (facebook#8372)

commit ca0ce82
Author: Bob Ippolito <bob@redivi.com>
Date:   Wed Apr 22 12:57:28 2026 -0700

    [lexical-list] Bug Fix: Ensure that ListItemNode always has a ListItem parent (facebook#8382)

commit f4c44e1
Author: Sherry <potatowagon@meta.com>
Date:   Thu Apr 23 00:28:54 2026 +0530

    [lexical-markdown] Bug Fix: Code spans take precedence over inline formatting in shortcuts (facebook#8381)

commit 4a43cb0
Author: Sergey Gorbachev <grbchv.s@gmail.com>
Date:   Wed Apr 22 18:31:21 2026 +0300

    [lexical-playground] Feature: HTML conversion button (facebook#8379)
levensta added a commit to levensta/lexical that referenced this pull request Apr 24, 2026
commit 5d1bc33
Author: Sathvik Veerapaneni <98241593+Sathvik-Chowdary-Veerapaneni@users.noreply.github.com>
Date:   Thu Apr 23 13:12:21 2026 -0400

    [lexical-list] Bug Fix: Merge nested list into parent <li> during HTML export (facebook#8313)

    Co-authored-by: Bob Ippolito <bob@redivi.com>

commit 2c37dc2
Author: Bob Ippolito <bob@redivi.com>
Date:   Thu Apr 23 07:14:14 2026 -0700

    [lexical-clipboard][lexical-rich-text][lexical-plain-text] Bug Fix: Drag-and-drop within the same block (facebook#8373)

    Co-authored-by: Claude <noreply@anthropic.com>

commit ca2aa31
Author: Bob Ippolito <bob@redivi.com>
Date:   Thu Apr 23 07:12:43 2026 -0700

    [lexical][lexical-utils][lexical-list] Bug Fix: Clean up and test $insertNodeToNearestRootAtCaret edge cases (facebook#8384)

commit 207648e
Author: Bob Ippolito <bob@redivi.com>
Date:   Thu Apr 23 07:11:52 2026 -0700

    [lexical-html][lexical-playground] Feature: Implement a well-defined ordering for DOMRenderExtension overrides and add $decorateDOM (facebook#8368)

commit 1ca42f1
Author: Agyei Holy <agyeiholy978@gmail.com>
Date:   Wed Apr 22 15:39:37 2026 -0500

    [lexical][lexical-code-core][lexical-list][lexical-table][lexical-yjs] Refactor: make runtime style updates CSP-safe (facebook#8372)

commit ca0ce82
Author: Bob Ippolito <bob@redivi.com>
Date:   Wed Apr 22 12:57:28 2026 -0700

    [lexical-list] Bug Fix: Ensure that ListItemNode always has a ListItem parent (facebook#8382)

commit f4c44e1
Author: Sherry <potatowagon@meta.com>
Date:   Thu Apr 23 00:28:54 2026 +0530

    [lexical-markdown] Bug Fix: Code spans take precedence over inline formatting in shortcuts (facebook#8381)

commit 4a43cb0
Author: Sergey Gorbachev <grbchv.s@gmail.com>
Date:   Wed Apr 22 18:31:21 2026 +0300

    [lexical-playground] Feature: HTML conversion button (facebook#8379)
@etrepum etrepum mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants