[lexical] Bug Fix: respect CSS scroll-padding in scrollIntoViewIfNeeded#8218
Merged
etrepum merged 3 commits intofacebook:mainfrom Mar 13, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Mar 13, 2026
| const rootElement = editor.getRootElement()!; | ||
| const doc = rootElement.ownerDocument; | ||
|
|
||
| // Mock scrollBy to capture scroll amounts |
Collaborator
There was a problem hiding this comment.
might be cleaner to use vi.spyOn instead of manually applying and resetting the mock
Contributor
Author
There was a problem hiding this comment.
Thank you for the feedback ! I implemented your suggestion.
etrepum
approved these changes
Mar 13, 2026
levensta
pushed a commit
to levensta/lexical
that referenced
this pull request
Mar 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scroll-padding-topandscroll-padding-bottomon the document elementCloses #6016
Test Plan
pnpm run test-unit packages/lexical/src/__tests__/unit/LexicalUtils.test.tspasses