[lexical-markdown] Fix: Prevent markdown shortcut link transformer from being too greedy#8161
Merged
etrepum merged 1 commit intofacebook:mainfrom Feb 22, 2026
Merged
Conversation
…om being too greedy
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
commented
Feb 21, 2026
| /(?:\[(.+?)\])(?:\((?:([^()\s]+)(?:\s"((?:[^"]*\\")*[^"]*)"\s*)?)\))/, | ||
| regExp: | ||
| /(?:\[(.+?)\])(?:\((?:([^()\s]+)(?:\s"((?:[^"]*\\")*[^"]*)"\s*)?)\))$/, | ||
| /(?:\[([^[\]]*(?:\[[^[\]]*\][^[\]]*)*)\])(?:\((?:([^()\s]+)(?:\s"((?:[^"]*\\")*[^"]*)"\s*)?)\))$/, |
Collaborator
Author
There was a problem hiding this comment.
I did let claude update this based on the tests I wrote, I did not thoroughly audit it to make sure that it passes the entire commonmark spec, but it does a better job than what was there before.
ivailop7
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The RegExp used for the link markdown transformer was too greedy and could match a preceding link with unbalanced brackets if two are processed on the same line.
Closes #8129
Closes #8130
Test plan
New unit tests to confirm that import works as expected and that it now works correctly with shortcuts