The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lexical	Ready	Preview, Comment	Feb 24, 2026 10:34pm
lexical-playground	Ready	Preview, Comment	Feb 24, 2026 10:34pm

Hi @kenclaron!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

I don't have strong opinions about handling CMD+Y specifically, all of the Mac browsers have it bound to "Show all History" by default. I think the only people who would try that keyboard shortcut are people who are not used to macOS that happen to be using a mac.

I think probably a higher priority should be abstracting all of the built-in keyboard shortcuts so that they are provided by an extension that makes it easier to reconfigure them, right now it's pretty awkward to override any key handling. That way an app can decide if it should behave this way (e.g. for a full page document editor) or if it would be better to follow native conventions.

For the context of this PR specifically my primary concern is that I don't know how it behaves with a keyboard map that maps ascii to ascii, e.g. dvorak or azerty. Possibly it should have a check to make sure that the key is non-ascii before trying the code, or maybe some of these shortcuts should only check the code? I don't have a windows machine to test and playwright doesn't support any keyboard remapping.

By the way, Google Docs can workaround the default behavior of Cmd + Y in browsers on MacOS

Yes, google docs can override cmd+y, but if you're using lexical for a form field or a chat input or something like that you might not want it to do that by default.

FWIW at least on macOS the shortcut behavior when using ASCII remapping (e.g. dvorak) is that the shortcuts map to the logical key and not the physical key code. If you press Cmd+KeyB (physical key code) with a dvorak mapping it executes the logical key Cmd+X action (in native apps also, not just chrome). No idea how Windows users expect this to behave, but perhaps the right workaround is to make sure that the key is non-ascii before trying the code fallback.

@kenclaron will you continue working on this PR? As a user of the Cyrillic keyboard layout, I am very interested in seeing this fix included in the lexical core

Looks like there's a small fix left to make it work and get compatible

Thanks for comments!

I added an additional check for non-standard keyboard layouts with ASCII characters (e.g. English/Dvorak) so that it works only on event.key as previously (not both event.key and event.code), by your comments. And added 1 jest-test for that user case.

About "we should incorporate the CMD + Y behavior as a standardized behavior". so I revert it part of code from the PR for now.