Skip to content

[lexical-history] Bug Fix: History not record composing character#8142

Merged
etrepum merged 2 commits intofacebook:mainfrom
Senasiko:main
Feb 16, 2026
Merged

[lexical-history] Bug Fix: History not record composing character#8142
etrepum merged 2 commits intofacebook:mainfrom
Senasiko:main

Conversation

@Senasiko
Copy link
Copy Markdown
Contributor

Description

Describe the changes in this pull request
Currently, there are a few issues with composition related to history and text format:

  1. If the selection's focus node has formatting, the first character of the composition is automatically selected.

before

selection-before.mp4

after

selection-after.mp4
  1. composing characters are pushed into the history stack.

before

history-before.mp4

after

history-after.mp4

additional, if input time less than delay, compostion words will be merged into prev state.

merge.mp4

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Feb 16, 2026 5:44pm
lexical-playground Ready Ready Preview, Comment Feb 16, 2026 5:44pm

Request Review

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2026
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Feb 14, 2026
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good approach, using tags is a simple way to communicate between the core and the history extension

@etrepum etrepum added this pull request to the merge queue Feb 16, 2026
Merged via the queue into facebook:main with commit c32268a Feb 16, 2026
35 checks passed
rayterion pushed a commit to rayterion/lexical that referenced this pull request Feb 18, 2026
@etrepum etrepum mentioned this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants