Skip to content

[lexical] Chore: Stabilize playground collab WebKit E2E test waits#8113

Merged
etrepum merged 2 commits intofacebook:mainfrom
screenfluent:fix-8112-stabilize-collab-webkit
Feb 5, 2026
Merged

[lexical] Chore: Stabilize playground collab WebKit E2E test waits#8113
etrepum merged 2 commits intofacebook:mainfrom
screenfluent:fix-8112-stabilize-collab-webkit

Conversation

@screenfluent
Copy link
Copy Markdown
Contributor

@screenfluent screenfluent commented Feb 3, 2026 •
edited
Loading

Fixes #8112.

This replaces a couple of short fixed sleeps in packages/lexical-playground/tests/e2e/Collaboration.spec.mjs with explicit waits:

  • Wait for the Undo button to be enabled before clicking (removes sleep(50)).
  • Wait for both editors to converge after the first delete before performing the second cross-frame delete (removes sleep(50)).

No behavior assertions changed; this only makes the existing test steps more deterministic.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment Feb 4, 2026 11:23am
lexical-playground Ready Ready Preview, Comment Feb 4, 2026 11:23am

Request Review

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Feb 3, 2026

Hi @screenfluent!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Feb 3, 2026
@etrepum
Copy link
Copy Markdown
Collaborator

etrepum commented Feb 4, 2026

This PR can't be considered without acceptance of the CLA, and it seems to be failing the prettier ci-check. pnpm run prettier:fix should address that issue.

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Feb 4, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Feb 4, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@screenfluent
Copy link
Copy Markdown
Contributor Author

screenfluent commented Feb 4, 2026

This PR can't be considered without acceptance of the CLA, and it seems to be failing the prettier ci-check. pnpm run prettier:fix should address that issue.

Hey @etrepum thanks! CLA is accepted and the Prettier check is fixed now, so the PR should be ready for review.

@etrepum etrepum changed the title Stabilize playground collab WebKit E2E waits [lexical] Chore: Stabilize playground collab WebKit E2E waits Feb 5, 2026
@etrepum etrepum changed the title [lexical] Chore: Stabilize playground collab WebKit E2E waits [lexical] Chore: Stabilize playground collab WebKit E2E test waits Feb 5, 2026
@etrepum etrepum enabled auto-merge February 5, 2026 00:35
@etrepum etrepum added this pull request to the merge queue Feb 5, 2026
Merged via the queue into facebook:main with commit 20fbe95 Feb 5, 2026
69 of 70 checks passed
@screenfluent screenfluent mentioned this pull request Feb 5, 2026
Merged
rayterion pushed a commit to rayterion/lexical that referenced this pull request Feb 8, 2026
@screenfluent @rayterion
[lexical] Chore: Stabilize playground collab WebKit E2E test waits (f…
f5c90b3 
…acebook#8113)
@etrepum etrepum mentioned this pull request Feb 25, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky WebKit collab E2E tests in playground (sleep(50) too short)

2 participants

@screenfluent @etrepum