[lexical] Bug Fix: Prevent layout thrashing when setting element indent for no indent case#8111
Merged
InanBerkin merged 1 commit intomainfrom Feb 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Feb 2, 2026
rayterion
pushed a commit
to rayterion/lexical
that referenced
this pull request
Feb 8, 2026
…nt for no indent case (facebook#8111)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the editor is loaded, browser is forced to recalculate style because of
getComputedStylecall insetElementIndent.Previously, even when indent was 0,
getComputedStylewas called but last style change was settingpadding-inline-startto ''. With this change, I am avoiding callinggetComputedStylefor the case where indent is 0 and returning early.Layout thrash: https://web.dev/articles/avoid-large-complex-layouts-and-layout-thrashing
Closes #
Test plan
Before
See "Recalculate style" caused by
setElementIndentin the profilerAfter
"Recalculate style" is still there but caused by another function (
updateDOMSelection)Indentation works
https://github.com/user-attachments/assets/c41c07cc-2dfc-4337-8a8a-ca6689d089c7
Profiler results
indent_recalc.gz
without_indent_recalc.gz