Fix(table): Support 'scope' attribute in HTML import.#8094
Merged
etrepum merged 3 commits intofacebook:mainfrom Feb 5, 2026
Merged
Fix(table): Support 'scope' attribute in HTML import.#8094etrepum merged 3 commits intofacebook:mainfrom
etrepum merged 3 commits intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
reviewed
Jan 30, 2026
Comment on lines
+19
to
+23
| import { | ||
| $convertTableCellNodeElement, | ||
| TableCellNode, | ||
| } from '../../LexicalTableCellNode'; | ||
|
|
Collaborator
There was a problem hiding this comment.
It would be better to test the public interface here rather than import these implementation details
Contributor
Author
There was a problem hiding this comment.
Good point. I've refactored the tests to use TableCellNode.importDOM() instead of importing the internal helper function directly. Checks passed!
41ab693 to
ed91fb5
Compare
etrepum
reviewed
Feb 4, 2026
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
the tests seem a bit weird, were these types generated by an llm or something? __headerState is even technically part of the public interface, /** @internal */ just means it's not documented.
| const node = result!.node as TableCellNode; | ||
|
|
||
| expect( | ||
| (node as TableCellNode & {__headerState: number}).__headerState, |
Collaborator
There was a problem hiding this comment.
I don't know why you're doing this cast?
Suggested change
| (node as TableCellNode & {__headerState: number}).__headerState, | |
| node.getHeaderState(), |
| const node = result!.node as TableCellNode; | ||
|
|
||
| expect( | ||
| (node as TableCellNode & {__headerState: number}).__headerState, |
Collaborator
There was a problem hiding this comment.
Suggested change
| (node as TableCellNode & {__headerState: number}).__headerState, | |
| node.getHeaderState(), |
| const node = result!.node; | ||
|
|
||
| expect( | ||
| (node as TableCellNode & {__headerState: number}).__headerState, |
Collaborator
There was a problem hiding this comment.
Suggested change
| (node as TableCellNode & {__headerState: number}).__headerState, | |
| node.getHeaderState(), |
|
|
||
| const result = convertHTMLTag(th); | ||
|
|
||
| const node = result!.node as TableCellNode; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const node = result!.node as TableCellNode; | |
| const node = result!.node; | |
| assert($isTableCellNode(node), 'Expected TableCellNode'); |
|
|
||
| const result = convertHTMLTag(th); | ||
|
|
||
| const node = result!.node as TableCellNode; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const node = result!.node as TableCellNode; | |
| const node = result!.node; | |
| assert($isTableCellNode(node), 'Expected TableCellNode'); |
| // No scope attribute set | ||
| const result = convertHTMLTag(th); | ||
|
|
||
| const node = result!.node; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const node = result!.node; | |
| const node = result!.node; | |
| assert($isTableCellNode(node), 'Expected TableCellNode'); |
…tyles() for strict assertions
etrepum
approved these changes
Feb 5, 2026
rayterion
pushed a commit
to rayterion/lexical
that referenced
this pull request
Feb 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the table cell importer assumes all
<th>elements are Row Headers. This ignores the scope attribute if present (e.g.,<th scope="col">), leading to incorrect header states for semantic tables.Fix: Updated $convertTableCellNodeElement to check for scope="col" and scope="row". It defaults to Row Header if scope is missing, preserving existing fallback behavior while enabling high-fidelity imports for semantic HTML.
Tests: Added unit tests in LexicalTableCellNode.test.ts to verify scope="col", scope="row", and missing scope scenarios.