[lexical-react] [lexical-playground] Remove old ContextMenu, consolidate LexicalMenu render#7984
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
left a comment
There was a problem hiding this comment.
Looks like mostly just code deletion, doesn't seem to affect any tests. I didn't try and interact with any of the playground related to these features.
I think the missing thing here is to mostly clearly document this as a breaking change so it doesn't get missed in the release notes
|
I fixed up the description but it might be a good idea to write up a quick example of what migration looks like in case anyone is depending on the deprecated API. We also don't have API docs for the old or new APIs. |
| embedFn: () => void, | ||
| dismissFn: () => void, | ||
| ) => Array<AutoEmbedOption>, | ||
| menuRenderFn: MenuRenderFn<AutoEmbedOption>, |
There was a problem hiding this comment.
This is a breaking change (React package), was this intentional? Do we still have an option to customize the menu now? @ivailop7
There was a problem hiding this comment.
it's using the typeahead menu styles for all LexicalMenu-based menus, excluding the ContextMenu-one those are definable in the theme object.
Re-applies PR #7984's menu consolidation while keeping menuRenderFn as an optional prop for backward compatibility. Old consumers that pass menuRenderFn still work; new consumers get the default className-based rendering. Also removes deprecated LexicalContextMenuPlugin (zero consumers).
Re-applies PR #7984's menu consolidation while keeping menuRenderFn as an optional prop for backward compatibility. Old consumers that pass menuRenderFn still work; new consumers get the default className-based rendering. Also removes deprecated LexicalContextMenuPlugin (zero consumers).
Breaking Changes
Removes deprecated
LexicalContextMenuAPI from@lexical/reactfor theLexicalNodeContextMenuAPI introduced in v0.32.0 (#7509)Before
Now
A complete usage example is available here
Description