[lexical-table] Bug Fix: Handle accessing table selection following table deletion#7864
Merged
etrepum merged 2 commits intofacebook:mainfrom Sep 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Sep 25, 2025
Merged
ayoubjemai
pushed a commit
to masar-edu/masar-doc-editor
that referenced
this pull request
Feb 7, 2026
ayoubjemai
pushed a commit
to masar-edu/masar-doc-editor
that referenced
this pull request
Feb 7, 2026
ayoubjemai
pushed a commit
to masar-edu/masar-doc-editor
that referenced
this pull request
Feb 7, 2026
ayoubjemai
pushed a commit
to masar-edu/masar-doc-editor
that referenced
this pull request
Feb 7, 2026
ayoubjemai
pushed a commit
to masar-edu/masar-doc-editor
that referenced
this pull request
Feb 7, 2026
ayoubjemai
pushed a commit
to masar-edu/masar-doc-editor
that referenced
this pull request
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you have a table selection, delete the table, then access that selection immediately afterwards (eg
selection.getNode()), and error is thrown ("node not found"). This can occur via an update listener as shown in #7140It is also common in collab scenarios where one client has a table selection and another client deletes the selected rows.
I have reproduced the error in a unit test, and fixed it by adding extra checks in
getNodesto detect the invalid selection.fixes #7140
Test plan
Added unit text reproducing the error
Error: Point.getNode: node not foundTest passes with code fix