[lexical] Fix: insert into existing paragraph node if selection is on parent element#7794
Merged
etrepum merged 1 commit intofacebook:mainfrom Sep 2, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
etrepum
approved these changes
Sep 2, 2025
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
Looks good and it fixes an issue that was recently opened so I updated the description accordingly. I suspect that there are some other quirks related to selections that should've been normalized differently.
Merged
polyrainbow
added a commit
to polyrainbow/neno
that referenced
this pull request
Sep 5, 2025
Upstream fix: facebook/lexical#7794
polyrainbow
added a commit
to polyrainbow/neno
that referenced
this pull request
Sep 5, 2025
Upstream fix: facebook/lexical#7794 Co-authored-by: Sebastian <polyrainbow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the selection is on the root node with an offset that points to a paragraph node, inserting text at the selection creates a new paragraph rather than inserting text into the existing paragraph. Noticed in collab when focusing the editor with the keyboard (i.e. refresh page, click frame outside of editor, tab into the content-editable).
Fixes #7789
Test plan
Before
Focusing editors by keyboard then inserting text results in new paragraphs being added, despite the cursor being positioned at the start of the paragraphs.
Screen.Recording.2025-09-02.at.5.29.12.pm.mov
After
Text is inserted into the existing paragraph.
Screen.Recording.2025-09-02.at.5.31.23.pm.mov