Skip to content

[lexical-link] Chore: Fix test names#7666

Merged
etrepum merged 5 commits intofacebook:mainfrom
noamzaks:main
Jul 4, 2025
Merged

[lexical-link] Chore: Fix test names#7666
etrepum merged 5 commits intofacebook:mainfrom
noamzaks:main

Conversation

@noamzaks
Copy link
Copy Markdown
Contributor

@noamzaks noamzaks commented Jul 3, 2025

Will look later for other possible places with this sort of issue

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:07am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:07am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2025
Co-authored-by: Bob Ippolito <bob@redivi.com>
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These typo fixes look correct, up to you if you want to do more auditing or move it out of draft status for merge

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label Jul 3, 2025
@noamzaks noamzaks marked this pull request as ready for review July 4, 2025 12:03
@noamzaks
Copy link
Copy Markdown
Contributor Author

noamzaks commented Jul 4, 2025

Thanks for the quick review.

I'm quite busy migrating my app to Lexical (a smoother process than expected!) so it might be best to merge now and hopefully I can look later to try and find similar cases.

@etrepum etrepum added this pull request to the merge queue Jul 4, 2025
Merged via the queue into facebook:main with commit 7fb5cc0 Jul 4, 2025
38 checks passed
@etrepum etrepum mentioned this pull request Jul 10, 2025
fantactuka pushed a commit that referenced this pull request Aug 11, 2025
Co-authored-by: Bob Ippolito <bob@redivi.com>
kizzlah pushed a commit to kizzlah/lexical that referenced this pull request Mar 8, 2026
Co-authored-by: Bob Ippolito <bob@redivi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants