[lexical-list] Bug Fix: Make tap target for checklists bigger so touch inputs register#7655
Merged
etrepum merged 3 commits intofacebook:mainfrom Jul 3, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Does this respect CSS zoom after ignoring the calculateZoom scaling? |
Contributor
Author
|
@ivailop7 it does now. Sorry, I didn't fully understand what was going on there. Applying zoom: 2 to the body worked in Chrome and Firefox, but I see now that it caused problems in Safari. |
0d1a70f to
6b88ced
Compare
6b88ced to
0d1a70f
Compare
etrepum
approved these changes
Jul 3, 2025
Collaborator
etrepum
left a comment
There was a problem hiding this comment.
Seems to work well!
I did notice that there's a bug with LexicalMenu along the way but that's unrelated to this PR: if you use the component picker to create the checklist then it will leave an empty div on top of the second checkbox preventing clicks or touches.
This was referenced Jul 3, 2025
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
…h inputs register (#7655)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the area in which touch events are registered bigger
Closes #7651