[lexical-react] Bug Fix: aria-prohibited-attr violation on LexicalContentEditableElement#7647
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @so99ynoodles! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
etrepum
left a comment
There was a problem hiding this comment.
This change causes other tests to fail
|
I think this looks fine but maybe @zurfyx should take a look |
…tentEditableElement (#7647)
Description
Describe the changes in this pull request
rolein read-only editor leads to an a11y violationaria-prohibited-attrCloses #7500
Test plan
jest-axefor a11y checkBefore
npm run test-unit packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsxAfter
npm run test-unit packages/lexical-react/src/__tests__/unit/LexicalContentEditableElement.test.tsx