Skip to content

[lexical-devtools-core] Chore: add NodeState to TreeView#7642

Merged
etrepum merged 3 commits intofacebook:mainfrom
randal-atticus:treeview-show-node-state
Jun 24, 2025
Merged

[lexical-devtools-core] Chore: add NodeState to TreeView#7642
etrepum merged 3 commits intofacebook:mainfrom
randal-atticus:treeview-show-node-state

Conversation

@randal-atticus
Copy link
Copy Markdown
Contributor

Description

Adds NodeState to TreeView, aiding debugging

Test plan

Before

Screenshot 2025-06-24 at 12 03 42 pm

After

Screenshot 2025-06-24 at 12 03 15 pm

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 6:11am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 6:11am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
Co-authored-by: Bob Ippolito <bob@redivi.com>
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider expanding this support to other node types, the only node in the playground that currently uses NodeState is the PollNode and decorators don't have any default print at all. Checked it out locally and made that modification just to test that this was working

Screenshot 2025-06-24 at 08 56 12

@etrepum etrepum added this pull request to the merge queue Jun 24, 2025
Merged via the queue into facebook:main with commit 960adf9 Jun 24, 2025
69 of 70 checks passed
@etrepum etrepum mentioned this pull request Jul 3, 2025
fantactuka pushed a commit that referenced this pull request Aug 11, 2025
Co-authored-by: Bob Ippolito <bob@redivi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants