[tests] Chore: Update table test to use locator API instead of page.evaluate#7603
Merged
etrepum merged 1 commit intofacebook:mainfrom Jun 4, 2025
Merged
[tests] Chore: Update table test to use locator API instead of page.evaluate#7603etrepum merged 1 commit intofacebook:mainfrom
etrepum merged 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivailop7
approved these changes
Jun 4, 2025
Merged
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that this table test failed for no particular reason and saw that it was using an awkward API to check its condition. Using locators and the playwright expect API should be a bit more resilient. I didn't see any other usage of
page.evaluatethat looked suspect.Test plan
Before
Test sometimes fails
After
Hopefully it fails less