Skip to content

[lexical] Fix: ctrl+a doesn't work well in plain text mode on Firefox#7579

Merged
etrepum merged 3 commits intofacebook:mainfrom
wataru-chocola:fix_select_all_on_firefox
Jun 4, 2025
Merged

[lexical] Fix: ctrl+a doesn't work well in plain text mode on Firefox#7579
etrepum merged 3 commits intofacebook:mainfrom
wataru-chocola:fix_select_all_on_firefox

Conversation

@wataru-chocola
Copy link
Copy Markdown
Contributor

@wataru-chocola wataru-chocola commented May 29, 2025 •
edited
Loading

Description

Enable override of selectall introduced by #4671 for Firefox.

Closes #7578

Test plan

Before

before

After

after

@vercel
Copy link
Copy Markdown

vercel bot commented May 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 10:40pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 10:40pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2025
@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label May 29, 2025
@wataru-chocola wataru-chocola marked this pull request as ready for review May 29, 2025 02:06
@wataru-chocola wataru-chocola force-pushed the fix_select_all_on_firefox branch from 7c611e5 to fefb2df Compare May 29, 2025 08:24
@wataru-chocola
Copy link
Copy Markdown
Contributor Author

wataru-chocola commented May 29, 2025

Fixed test cases.

I skipped selectAll related tests if os is linux and browser is firefox, because selectAll in keyboardShortcuts/index.mjs does emulation on the condition and tests won't work.

etrepum
etrepum reviewed May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think skipping the tests is the best approach, especially because it means that the tests don't cover what you're trying to fix here

@wataru-chocola wataru-chocola force-pushed the fix_select_all_on_firefox branch from fefb2df to b5f08be Compare May 30, 2025 00:01
@wataru-chocola
Copy link
Copy Markdown
Contributor Author

wataru-chocola commented May 30, 2025

I don't think skipping the tests is the best approach, especially because it means that the tests don't cover what you're trying to fix here

You are right.
I fixed test cases again.

etrepum
etrepum approved these changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, do you have any opinion on it @zurfyx?

@etrepum etrepum added this pull request to the merge queue Jun 4, 2025
Merged via the queue into facebook:main with commit bb9fb20 Jun 4, 2025
60 of 64 checks passed
@etrepum etrepum mentioned this pull request Jun 4, 2025
Merged
fantactuka pushed a commit that referenced this pull request Aug 11, 2025
@wataru-chocola @etrepum @fantactuka
[lexical] Fix: ctrl+a doesn't work well in plain text mode on Firefox (…
ede3ea2 
…#7579)

Co-authored-by: Bob Ippolito <bob@redivi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

@lilshady lilshady Awaiting requested review from lilshady

@takuyakanbr takuyakanbr Awaiting requested review from takuyakanbr takuyakanbr is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Ctrl+A doesn't work well in PlainTextPlugin on Firefox

3 participants

@wataru-chocola @etrepum @facebook-github-bot