[WIP][lexical-table] Feature: Use custom selection behavior for table cell triple click#7005
Closed
etrepum wants to merge 2 commits into
Closed
[WIP][lexical-table] Feature: Use custom selection behavior for table cell triple click#7005etrepum wants to merge 2 commits into
etrepum wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
kirandash
added a commit
to bgwebagency/lexical
that referenced
this pull request
Feb 20, 2025
This commit fixes the issue where triple-clicking a table cell would incorrectly select adjacent cells. The implementation is based on @etrepum's approach from PR facebook#7005. The fix adds two new handlers: - Adds to: - Handle triple-click events in table cells - Check if block's parent is a table cell - Select only the block within the cell - Prevent selection of adjacent cells - Adds removeTripleClickHandler to: - Prevent default browser behavior for triple clicks - Use capture phase for event listeners - Handle all clicks >= 3 consistently Both handlers work together to ensure proper table cell selection behavior without affecting adjacent cells. Fixes facebook#6973 Co-authored-by: Bob Ippolito <bob@redivi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The native browser triple click over-selects in tables compared to the expectation of selecting the cell. By adding a click handler that looks for
detail === 3we can detect this event and customize the behavior.TODO:
Closes #6973
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
Insert relevant screenshots/recordings/automated-tests