Revert "[@lexical/playground] fix: block cursor show horizontal"#6490
Merged
Revert "[@lexical/playground] fix: block cursor show horizontal"#6490
Conversation
This reverts commit 65bdd2c.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Collaborator
Author
|
/cc @ivailop7 |
ivailop7
approved these changes
Aug 4, 2024
jkjk822
pushed a commit
to jkjk822/lexical
that referenced
this pull request
Aug 26, 2024
This was referenced Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6486
RE #6459
The horizontal cursor is desired in cases where the selection would otherwise be visually ambiguous. This can be reproduced by clearing the editor, creating a table node, selecting before the table node, and pressing up to get a selection at the root node.
Before revert:
block-cursor-before-revert.mov
After revert:
block-cursor-after-revert.mov