Skip to content

[lexical] Bug Fix: Merge pasted paragraph into empty quote#6367

Merged
etrepum merged 15 commits intofacebook:mainfrom
2wheeh:fix-quote-paste-para
Aug 2, 2024
Merged

[lexical] Bug Fix: Merge pasted paragraph into empty quote#6367
etrepum merged 15 commits intofacebook:mainfrom
2wheeh:fix-quote-paste-para

Conversation

@2wheeh
Copy link
Copy Markdown
Contributor

@2wheeh 2wheeh commented Jul 2, 2024

Description

It adds handling for pasting paragraph into an empty quote node.

Closes #5108

Test plan

Before

2024-07-03.1.43.53.mov

After

2024-07-03.1.42.24.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2024
@vercel
Copy link
Copy Markdown

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 11:22pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 11:22pm

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.05 KB (0%)
lexical - esm 28.86 KB (0%)
@lexical/rich-text - cjs 37.39 KB (0%)
@lexical/rich-text - esm 28.33 KB (0%)
@lexical/plain-text - cjs 36.02 KB (0%)
@lexical/plain-text - esm 25.6 KB (0%)
@lexical/react - cjs 39.29 KB (0%)
@lexical/react - esm 29.77 KB (0%)

etrepum
etrepum reviewed Jul 2, 2024
View reviewed changes
@2wheeh 2wheeh force-pushed the fix-quote-paste-para branch from 0f7b95d to 86a233d Compare July 17, 2024 16:40
@2wheeh 2wheeh force-pushed the fix-quote-paste-para branch from 86a233d to 8e97547 Compare July 17, 2024 16:40
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Jul 17, 2024
@2wheeh

This comment was marked as resolved.

Sign in to view
@2wheeh
Copy link
Copy Markdown
Contributor Author

2wheeh commented Jul 26, 2024

@etrepum @StyleT Thank you. I added jsdoc here.

@2wheeh
Copy link
Copy Markdown
Contributor Author

2wheeh commented Jul 26, 2024

Failure of e2e-tests / prod (macos-latest) ... is due to #6463

etrepum
etrepum approved these changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etrepum etrepum added this pull request to the merge queue Aug 2, 2024
Merged via the queue into facebook:main with commit 3c53e64 Aug 2, 2024
@2wheeh 2wheeh deleted the fix-quote-paste-para branch August 3, 2024 00:39
jkjk822 pushed a commit to jkjk822/lexical that referenced this pull request Aug 26, 2024
@2wheeh @etrepum @jkjk822
[lexical] Bug Fix: Merge pasted paragraph into empty quote (facebook#…
e0d66b1 
…6367)

Co-authored-by: Bob Ippolito <bob@redivi.com>
This was referenced Sep 28, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etrepum etrepum etrepum approved these changes

@StyleT StyleT StyleT left review comments

@acywatson acywatson acywatson left review comments

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@Fetz Fetz Awaiting requested review from Fetz

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Pasting into an empty quote node converts it to a paragraph

7 participants

@2wheeh @StyleT @GermanJablo @etrepum @acywatson @facebook-github-bot @ivailop7