When creating a new check list, set the checked value of the list item to false instead of undefined#5978
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const listItem = $createListItemNode(); | ||
| const listItem = $createListItemNode( | ||
| listType === 'check' ? false : undefined, | ||
| ); |
There was a problem hiding this comment.
wondering if its more appropriate to make the handling of this behaviour clearer inside packages/lexical-list/src/LexicalListItemNode.ts
There was a problem hiding this comment.
how about now? i've refactored LexicalListItemNode.getChecked() to always return a boolean if the parent list type is "check" and undefined otherwise.
|
packages/lexical-playground/tests/e2e/List.spec.mjs:1170:3 › Nested List › Can create check list, toggle it to bullet-list and back is breaking |
size-limit report 📦
|
…pe changes to bullet or number
|
Sorry for the long delay. Should be fixed now. |
etrepum
left a comment
There was a problem hiding this comment.
LGTM, seems reasonable to enforce this and the node transform should keep it consistent
…tem to `false` instead of `undefined` (facebook#5978)
At the moment, when creating a new checklist, the newly created list item doesn't have the
checkedset until the user manually toggles it. This PR makes sure that thecheckedvalue is set tofalseand notundefined.This also makes the behavior in line with the behavior when creating a check list using the markdown transformer.
lexical-checklist.mp4